[ffigen] Fix opaque struct in arr (#2545)

Author: mannprerak2

pkgs/ffigen/CHANGELOG.md

@@ -14,6 +14,7 @@
     object may change, but the underlying ObjC object will still be the same.
     In any case, you should be using `Foo.isInstance(x)` instead of `x is Foo`
     to check the runtime type of an ObjC object.
+- Fix for opaque dependencies for struct/union const arrays.
 
 ## 19.1.0
 

pkgs/ffigen/lib/src/visitor/opaque_compounds.dart

@@ -21,7 +21,7 @@ class FindByValueCompoundsVisitation extends Visitation {
 
   @override
   void visitPointerType(PointerType node) {
-    if (node.child.typealiasType is Compound) {
+    if (node.child.typealiasType is Compound && node is! ConstantArray) {
       // Don't visit compounds through pointers. We're only interested in
       // compounds that are referred to by value.
     } else {

pkgs/ffigen/test/header_parser_tests/expected_bindings/_expected_opaque_dependencies_bindings.dart

@@ -59,10 +59,20 @@ final class D extends ffi.Struct {
   external ffi.Pointer<NoDefinitionStructInD> nds;
 }
 
+final class DArray extends ffi.Struct {
+  @ffi.Int()
+  external int a;
+
+  external ffi.Pointer<NoDefinitionStructInD> nds;
+}
+
 final class E extends ffi.Struct {
   external ffi.Pointer<C> c;
 
   external D d;
+
+  @ffi.Array.multi([10])
+  external ffi.Array<DArray> dArray;
 }
 
 final class UA extends ffi.Opaque {}
@@ -76,8 +86,16 @@ final class UD extends ffi.Union {
   external int a;
 }
 
+final class UDArray extends ffi.Union {
+  @ffi.Int()
+  external int a;
+}
+
 final class UE extends ffi.Union {
   external ffi.Pointer<UC> c;
 
   external UD d;
+
+  @ffi.Array.multi([10])
+  external ffi.Array<UDArray> dArray;
 }

pkgs/ffigen/test/header_parser_tests/opaque_dependencies.h

@@ -30,11 +30,19 @@ struct D
     struct NoDefinitionStructInD* nds;
 };
 
+// Full (excluded, but used by value in an array).
+struct DArray
+{
+    int a;
+    struct NoDefinitionStructInD* nds;
+};
+
 // Full (included)
 struct E
 {
     struct C *c;
     struct D d;
+    struct DArray dArray[10];
 };
 
 // Opaque.
@@ -63,9 +71,16 @@ union UD
     int a;
 };
 
+// Full (excluded, but used by value in array).
+union UDArray
+{
+    int a;
+};
+
 // Full (included)
 union UE
 {
     union UC *c;
     union UD d;
+    union UDArray dArray[10];
 };