Add package name arg (#2391)

Author: mosuem

pkgs/native_toolchain_c/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.16.8
+
+* Support building assets for packages which are not the input package.
+
 ## 0.16.7
 
 * Support Module Definitions for linking on Windows.

pkgs/native_toolchain_c/lib/src/cbuilder/cbuilder.dart

@@ -53,6 +53,7 @@ class CBuilder extends CTool implements Builder {
 
   CBuilder.library({
     required super.name,
+    super.packageName,
     super.assetName,
     super.sources = const [],
     super.includes = const [],
@@ -81,6 +82,7 @@ class CBuilder extends CTool implements Builder {
 
   CBuilder.executable({
     required super.name,
+    super.packageName,
     super.sources = const [],
     super.includes = const [],
     super.forcedIncludes = const [],
@@ -203,7 +205,7 @@ class CBuilder extends CTool implements Builder {
       for (final route in routing) {
         output.assets.code.add(
           CodeAsset(
-            package: input.packageName,
+            package: packageName ?? input.packageName,
             name: assetName!,
             file: libUri,
             linkMode: linkMode,

pkgs/native_toolchain_c/lib/src/cbuilder/clinker.dart

@@ -23,6 +23,7 @@ class CLinker extends CTool implements Linker {
 
   CLinker.library({
     required super.name,
+    super.packageName,
     super.assetName,
     required this.linkerOptions,
     super.sources = const [],
@@ -99,7 +100,7 @@ class CLinker extends CTool implements Linker {
     if (assetName != null) {
       output.assets.code.add(
         CodeAsset(
-          package: input.packageName,
+          package: packageName ?? input.packageName,
           name: assetName!,
           file: libUri,
           linkMode: linkMode,

pkgs/native_toolchain_c/lib/src/cbuilder/ctool.dart

@@ -26,6 +26,11 @@ abstract class CTool {
   /// File will be placed in [LinkInput.outputDirectory].
   final String name;
 
+  /// The package name to associate the asset with.
+  ///
+  /// If this is null, it defaults to the [HookInput.packageName].
+  final String? packageName;
+
   /// Asset identifier.
   ///
   /// Used to output the [CodeAsset].
@@ -164,6 +169,7 @@ abstract class CTool {
 
   CTool({
     required this.name,
+    required this.packageName,
     required this.assetName,
     required this.sources,
     required this.includes,

pkgs/native_toolchain_c/pubspec.yaml

@@ -1,7 +1,7 @@
 name: native_toolchain_c
 description: >-
   A library to invoke the native C compiler installed on the host machine.
-version: 0.16.7
+version: 0.16.8
 repository: https://github.com/dart-lang/native/tree/main/pkgs/native_toolchain_c
 
 topics: