Fix printing of log messages on test failures (#147)

Author: blaugold

pkgs/native_assets_builder/test/helpers.dart

@@ -157,21 +157,32 @@ Future<void> copyTestProjects({
 }
 
 /// Logger that outputs the full trace when a test fails.
-final logger = Logger('')
-  ..level = Level.ALL
-  ..onRecord.listen((record) {
-    printOnFailure(record.message);
-  });
+Logger get logger => _logger ??= () {
+      // A new logger is lazily created for each test so that the messages
+      // captured by printOnFailure are scoped to the correct test.
+      addTearDown(() => _logger = null);
+      return _createTestLogger();
+    }();
+
+Logger? _logger;
 
 Logger createCapturingLogger(
   List<String> capturedMessages, {
   Level level = Level.ALL,
+}) =>
+    _createTestLogger(capturedMessages: capturedMessages, level: level);
+
+Logger _createTestLogger({
+  List<String>? capturedMessages,
+  Level level = Level.ALL,
 }) =>
     Logger('')
       ..level = level
       ..onRecord.listen((record) {
-        printOnFailure(record.message);
-        capturedMessages.add(record.message);
+        printOnFailure(
+          '${record.level.name}: ${record.time}: ${record.message}',
+        );
+        capturedMessages?.add(record.message);
       });
 
 final dartExecutable = File(Platform.resolvedExecutable).uri;

pkgs/native_assets_cli/example/native_add_library/build.dart

@@ -28,7 +28,9 @@ void main(List<String> args) async {
     // `package:native_toolchain_c` will output the dynamic or static libraries it built,
     // what files it accessed (for caching the build), etc.
     buildOutput: buildOutput,
-    logger: Logger('')..onRecord.listen((record) => print(record.message)),
+    logger: Logger('')
+      ..level = Level.ALL
+      ..onRecord.listen((record) => print(record.message)),
   );
 
   // Write the output according to the native assets protocol so that Dart or

pkgs/native_toolchain_c/test/helpers.dart

@@ -54,17 +54,23 @@ Future<Uri> tempDirForTest({String? prefix, bool keepTemp = false}) async {
 }
 
 /// Logger that outputs the full trace when a test fails.
-final logger = Logger('')
-  ..level = Level.ALL
-  ..onRecord.listen((record) {
-    printOnFailure('${record.level.name}: ${record.time}: ${record.message}');
-  });
+Logger get logger => _logger ??= () {
+      // A new logger is lazily created for each test so that the messages
+      // captured by printOnFailure are scoped to the correct test.
+      addTearDown(() => _logger = null);
+      return _createTestLogger();
+    }();
+
+Logger? _logger;
+
+Logger createCapturingLogger(List<String> capturedMessages) =>
+    _createTestLogger(capturedMessages: capturedMessages);
 
-Logger createCapturingLogger(List<String> capturedMessages) => Logger('')
+Logger _createTestLogger({List<String>? capturedMessages}) => Logger('')
   ..level = Level.ALL
   ..onRecord.listen((record) {
     printOnFailure('${record.level.name}: ${record.time}: ${record.message}');
-    capturedMessages.add(record.message);
+    capturedMessages?.add(record.message);
   });
 
 /// Test files are run in a variety of ways, find this package root in all.