Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add license headers #3165

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[WIP] Add license headers #3165

wants to merge 3 commits into from

Conversation

itsjustkevin
Copy link

Draft of license header additions, will reach out to the compliance office for further information before marking this as ready for review or closing.

closes #3163

@devoncarew
Copy link
Member

Note, this repo uses:

// Copyright (c) 20XX, the Dart project authors.  Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

And as a nit for the copyright year, I'd either use 2025 for expediency, or , use git blame for individual files to see when they were created.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ⚠️ 
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
pkgs/samples/lib/brick_breaker.dart
pkgs/samples/lib/fibonacci.dart
pkgs/samples/lib/google_ai.dart
pkgs/samples/lib/hello_world.dart
pkgs/samples/lib/main.dart
pkgs/samples/lib/sunflower.dart

All source files should start with a license header.

This check can be disabled by tagging the PR with skip-license-check.

devoncarew
devoncarew approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments, then I think this could land.

cc @johnpryan

pkgs/dartpad_ui/web/codemirror/codemirror.js
@@ -1,3 +1,7 @@
// Copyright 2013 The Flutter Authors. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert this change and open an issue on the repo to look at setting up a true third_party directory for this repo? We'll need to have a copy-code step (or perhaps, use a symlink?).

pkgs/dartpad_ui/web/require.js
@@ -1,3 +1,7 @@
// Copyright 2013 The Flutter Authors. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here; can you remove these lines and reference this file from the codemirror/codemirror.js
issues (created above)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoncarew devoncarew devoncarew approved these changes

@johnpryan johnpryan Awaiting requested review from johnpryan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DartPad is missing required license headers
2 participants
@itsjustkevin @devoncarew