Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DartPad is missing required license headers #3163

Open
itsjustkevin opened this issue Mar 3, 2025 · 3 comments · May be fixed by #3165
Open

DartPad is missing required license headers #3163

itsjustkevin opened this issue Mar 3, 2025 · 3 comments · May be fixed by #3165

Comments

@itsjustkevin
Copy link

Conducting an analysis of DartPad license compliance returned the following:

Missing license header

  • /.cloud_build/dart_pad.yaml
  • /.cloud_build/dart_services.yaml
  • /.cloud_build/firebase/cloudbuild.yaml
  • /.cloud_build/flutter/cloudbuild.yaml
  • /.github/dependabot.yaml
  • /.github/workflows/health.yaml
  • /.github/workflows/post_summaries.yaml
  • /pkgs/dart_services/analysis_options.yaml
  • /pkgs/dart_services/dart_test.yaml
  • /pkgs/dart_services/pubspec.yaml
  • /pkgs/dartpad_shared/analysis_options.yaml
  • /pkgs/dartpad_shared/lib/model.g.dart
  • /pkgs/dartpad_shared/pubspec.yaml
  • /pkgs/dartpad_ui/analysis_options.yaml
  • pkgs/dartpad_ui/devtools_options.yaml
  • /pkgs/dartpad_ui/lib/enable_gen_ai.dart
  • /pkgs/dartpad_ui/pubspec.yaml
  • /pkgs/dartpad_ui/web/codemirror/codemirror.js
  • /pkgs/dartpad_ui/web/ga.js
  • /pkgs/dartpad_ui/web/require.js
  • /pkgs/samples/analysis_options.yaml
  • /pkgs/samples/devtools_options.yaml
  • /pkgs/samples/pubspec.yaml
  • /pubspec.yaml
@parlough
Copy link
Member

parlough commented Mar 3, 2025

Do we need license headers for YAML files? We've never done so before.

\cc @devoncarew

@devoncarew
Copy link
Member

We never have; other teams do do so however: https://github.com/googleapis/google-cloud-rust/blob/main/generator/dart/pubspec.yaml. I'll see if there are any related docs (or @itsjustkevin, if you have any relevant links, can you share?).

@itsjustkevin itsjustkevin linked a pull request Mar 3, 2025 that will close this issue
@itsjustkevin
Copy link
Author

Will reach out to the compliance office for more information, this is also requesting the addition of a header to a generated file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants