-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider enabling the sound variance experiment. #2555
Comments
@mit-mit what experiments do you want running on DartPad master? |
I think we should have DartPad mirror the standard configuration of the SDK; it not it seems like it might get really confusing what the default developer experience is? |
It looks to me like most people will be using the stable channel on DartPad because that is the default. It could be confusing to some people, but we already have enabled inline-classes as an experiment and it doesn't seem like that has lead to any issues so far. Furthermore, the channel selector is pretty explicit that there are experiments enabled. The master channel + experiment flags are really convenient for discovering issues with the experiments. An alternative would be (which Erik proposed here) to have a "bleeding_edge" channel:
|
For example, the following issues were discovered because the master channel on DartPad enables inline-classes: dart-lang/sdk#52667 & dart-lang/sdk#52674 I'm trying to see if the sound variance experiment is far enough to deal with the following issue: dart-lang/language#3156. |
This experiment exist in years, and enabling it will maybe give the idea that it will be a default feature in the master branch (and thus, released in the next stable version). Instead, we should have a way of enabling/disabling for all experiments in the DartPad menu. |
Thanks for the suggestion and discussion here. For now, we'd like to avoid too much client side configuration in the DartPad UI, especially if it requires changes to the analysis configuration and context due to the setup of the backend. As for the sound variance experiment, we'll likely stick to only enabling experiments that are more likely to land in upcoming stable releases, and even then, only in the Perhaps we can revisit this in the future, but giving DartPad's current goals and support levels, I think this is the best way forward for now. Please feel free to continue the discussion though! |
@domesticmouse If possible, could the sound variance experiment be enabled on the master channel? (#2480 (comment))
The text was updated successfully, but these errors were encountered: