Skip to content

Add test for external constructor that initializes fields #2436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sgrekhov opened this issue Dec 15, 2023 · 0 comments
Closed

Add test for external constructor that initializes fields #2436

sgrekhov opened this issue Dec 15, 2023 · 0 comments
Assignees
@sgrekhov
Labels
type-enhancement A request for a change that isn't a bug

Comments

@sgrekhov
Copy link
Contributor

sgrekhov commented Dec 15, 2023 •
edited
Loading

Add test like

class C {
  num x;
  external C(this.x); // Error
}

main() {
  print(C);
}

See also dart-lang/language#3516
@sgrekhov sgrekhov added the type-enhancement A request for a change that isn't a bug label Dec 15, 2023
@sgrekhov sgrekhov self-assigned this Dec 15, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jan 2, 2024
@sgrekhov
Fixes dart-lang#2436. Add tests for external and redirecting construc…
468fb75 
…tors with initializing formals
@eernstg eernstg closed this as completed in 2ea77ca Jan 2, 2024
@sgrekhov sgrekhov reopened this Jan 2, 2024
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jan 3, 2024
@sgrekhov
Fixes dart-lang#2436. Add test for external constructors with initial…
535c038 
…izers
@eernstg eernstg closed this as completed in dce14c2 Jan 3, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jan 5, 2024
@sgrekhov
[co19] Roll co19 to cd23849a5bf84a73466b5107e23bb04cf3d9b38a
6cf1148 
2024-01-05 [email protected] Fixes dart-lang/co19#2465. Fix roll failures (dart-lang/co19#2466)
2024-01-04 [email protected] dart-lang/co19#2420. Add object-pattern exhaustiveness tests (dart-lang/co19#2454)
2024-01-04 [email protected] dart-lang/co19#2420. Add relational pattern exhaustiveness tests (dart-lang/co19#2463)
2024-01-03 [email protected] dart-lang/co19#2420. Add missed experimental flags (dart-lang/co19#2462)
2024-01-03 [email protected] Fixes dart-lang/co19#2436. Add test for external constructors with initializers (dart-lang/co19#2461)
2024-01-02 [email protected] dart-lang/co19#2420. Add more dynamic semantics extension type tests (dart-lang/co19#2459)
2024-01-02 [email protected] Fixes dart-lang/co19#2436. Add tests for external and redirecting constructors with initializing formals (dart-lang/co19#2460)
2023-12-29 [email protected] dart-lang/co19#1400. Add object pattern tests for extension types (dart-lang/co19#2456)
2023-12-29 [email protected] dart-lang/co19#1400. Add type inference tests for extension types (dart-lang/co19#2455)
2023-12-29 [email protected] dart-lang/co19#2420. Add switch statement check to the existing exhaustiveness tests (dart-lang/co19#2452)

Change-Id: Iee0668f14a35bb3c47aa67b35b1e5c6d8abe8021
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345040
Reviewed-by: William Hesse <[email protected]>
Commit-Queue: Erik Ernst <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jan 8, 2024
@sgrekhov
dart-lang#2436. Add expected constant evaluation error for CFE
f71e64f
eernstg pushed a commit that referenced this issue Jan 8, 2024
@sgrekhov
#2436. Add expected constant evaluation error for CFE (#2470)
3924345
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jan 12, 2024
@sgrekhov
[co19] Roll co19 to b5126f0bd51ea0819df8d5c362574f951a564940
f02b056 
2024-01-12 [email protected] Fixes dart-lang/co19#2480. Fix typos, add issue numbers (dart-lang/co19#2481)
2024-01-10 [email protected] dart-lang/co19#2477. Rename and reorder existing constants tests for match operators before adding new ones (dart-lang/co19#2478)
2024-01-10 [email protected] dart-lang/co19#2420. Add null-check-pattern tests for extension types (dart-lang/co19#2475)
2024-01-10 [email protected] dart-lang/co19#2119. Add missing experimental flags (dart-lang/co19#2474)
2024-01-10 [email protected] dart-lang/co19#2119. Fix typo and improve error messages in Timer tests (dart-lang/co19#2473)
2024-01-09 [email protected] Fixes dart-lang/co19#2471. Fix timer constructor tests. Add check for microtasks (dart-lang/co19#2472)
2024-01-09 [email protected] Fixes dart-lang/co19#2428. Add `call` member tests for extension types (dart-lang/co19#2438)
2024-01-09 [email protected] Fixes dart-lang/co19#2449. Update positions of analyzer expected errors (dart-lang/co19#2450)
2024-01-09 [email protected] Fixes dart-lang/co19#2440. Add asyncStart/End() to Stream interface tests (dart-lang/co19#2457)
2024-01-09 [email protected] dart-lang/co19#2420. Add another variable pattern exhaustiveness test (dart-lang/co19#2469)
2024-01-08 [email protected] dart-lang/co19#2420. Add constant pattern exhaustiveness tests (dart-lang/co19#2467)
2024-01-08 [email protected] dart-lang/co19#2436. Add expected constant evaluation error for CFE (dart-lang/co19#2470)
2024-01-08 [email protected] dart-lang/co19#2420. Add null-assert pattern exhaustiveness tests (dart-lang/co19#2468)
2024-01-05 [email protected] dart-lang/co19#2420. Add parenthesized pattern exhaustiveness tests (dart-lang/co19#2464)

Change-Id: I86862732cca7c042120bf312403279c2cc10c135
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345960
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Erik Ernst <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgrekhov