Skip to content
This repository was archived by the owner on Jun 3, 2020. It is now read-only.

Commit d17749f

Browse files
committed
Using dart:convert HtmlEscape; got rid of query()
1 parent 166509f commit d17749f

File tree

28 files changed

+110
-121
lines changed

28 files changed

+110
-121
lines changed

html5/lib/htmlescape.dart

-18
This file was deleted.

html5/tool/hop_runner.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ List<String> getDartPaths(htmlPaths) {
1818
for (var htmlPath in htmlPaths) {
1919
var file = new File(htmlPath).readAsStringSync();
2020
var contents = parse(file);
21-
var scripts = contents.body.queryAll("script");
21+
var scripts = contents.body.querySelectorAll("script");
2222
if (!scripts.isEmpty) {
2323
for(var script in scripts) {
2424
if (script.attributes['type'] == 'application/dart') {

html5/web/canvas/hidpi/hidpi.dart

+3-3
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ void drawImage(CanvasElement canvas, ImageElement image,
4242
}
4343

4444
void main() {
45-
CanvasElement canvas = query("#canvas");
46-
ImageElement pic = query("#pic");
45+
CanvasElement canvas = querySelector("#canvas");
46+
ImageElement pic = querySelector("#pic");
4747
drawImage(canvas, pic, desX: 10, desY: 10, desW: 300, desH: 90);
48-
}
48+
}

html5/web/dnd/basics/basics.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class Basics {
1212
Element _dragSourceEl;
1313

1414
void start() {
15-
var cols = document.queryAll('#columns .column');
15+
var cols = document.querySelectorAll('#columns .column');
1616
for (var col in cols) {
1717
col.onDragStart.listen(_onDragStart);
1818
col.onDragEnd.listen(_onDragEnd);
@@ -34,7 +34,7 @@ class Basics {
3434
void _onDragEnd(MouseEvent event) {
3535
Element dragTarget = event.target;
3636
dragTarget.classes.remove('moving');
37-
var cols = document.queryAll('#columns .column');
37+
var cols = document.querySelectorAll('#columns .column');
3838
for (var col in cols) {
3939
col.classes.remove('over');
4040
}

html5/web/file/dndfiles/dndfiles.dart

+10-8
Original file line numberDiff line numberDiff line change
@@ -5,22 +5,24 @@
55
// This is a port of "Reading Files in JavaScript Using the File APIs" to Dart.
66
// See: http://www.html5rocks.com/en/tutorials/file/dndfiles/
77

8+
import 'dart:convert' show HtmlEscape;
89
import 'dart:html';
9-
import 'package:dart_samples/htmlescape.dart';
10+
1011

1112
class DndFiles {
1213
FormElement _readForm;
1314
InputElement _fileInput;
1415
Element _dropZone;
1516
OutputElement _output;
17+
HtmlEscape sanitizer = new HtmlEscape();
1618

1719
DndFiles() {
18-
_output = document.query('#list');
19-
_readForm = document.query('#read');
20-
_fileInput = document.query('#files');
20+
_output = document.querySelector('#list');
21+
_readForm = document.querySelector('#read');
22+
_fileInput = document.querySelector('#files');
2123
_fileInput.onChange.listen((e) => _onFileInputChange());
2224

23-
_dropZone = document.query('#drop-zone');
25+
_dropZone = document.querySelector('#drop-zone');
2426
_dropZone.onDragOver.listen(_onDragOver);
2527
_dropZone.onDragEnter.listen((e) => _dropZone.classes.add('hover'));
2628
_dropZone.onDragLeave.listen((e) => _dropZone.classes.remove('hover'));
@@ -58,7 +60,7 @@ class DndFiles {
5860
reader.onLoad.listen((e) {
5961
var thumbnail = new ImageElement(src: reader.result);
6062
thumbnail.classes.add('thumb');
61-
thumbnail.title = htmlEscape(file.name);
63+
thumbnail.title = sanitizer.convert(file.name);
6264
thumbHolder.nodes.add(thumbnail);
6365
});
6466
reader.readAsDataUrl(file);
@@ -68,9 +70,9 @@ class DndFiles {
6870
// For all file types, display some properties.
6971
var properties = new Element.tag('span');
7072
properties.innerHtml = (new StringBuffer('<strong>')
71-
..write(htmlEscape(file.name))
73+
..write(sanitizer.convert(file.name))
7274
..write('</strong> (')
73-
..write(file.type != null ? htmlEscape(file.type) : 'n/a')
75+
..write(file.type != null ? sanitizer.convert(file.type) : 'n/a')
7476
..write(') ')
7577
..write(file.size)
7678
..write(' bytes')

html5/web/file/dndfiles/monitoring.dart

+4-4
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ class Monitoring {
1515
FileReader _reader;
1616

1717
Monitoring() {
18-
_progressBar = query('#progress-bar');
19-
_fileInput = document.query('#files');
18+
_progressBar = querySelector('#progress-bar');
19+
_fileInput = document.querySelector('#files');
2020
_fileInput.onChange.listen((e) => _onFilesSelected());
21-
var cancelButton = query('#cancel-read');
21+
var cancelButton = querySelector('#cancel-read');
2222
cancelButton.onClick.listen((e) => _onCancel());
2323
}
2424

@@ -79,4 +79,4 @@ class Monitoring {
7979

8080
void main() {
8181
new Monitoring();
82-
}
82+
}

html5/web/file/dndfiles/slicing.dart

+4-4
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,16 @@ class Slicing {
1313
Element _byteRange;
1414

1515
Slicing() {
16-
_content = query('#byte-content');
17-
_byteRange = query('#byte-range');
16+
_content = querySelector('#byte-content');
17+
_byteRange = querySelector('#byte-range');
1818

19-
_fileInput = query('#files');
19+
_fileInput = querySelector('#files');
2020
_fileInput.onChange.listen((e) {
2121
_content.text = '';
2222
_byteRange.text = '';
2323
});
2424

25-
var buttons = query('#read-bytes-buttons');
25+
var buttons = querySelector('#read-bytes-buttons');
2626
buttons.onClick.listen(_onClick);
2727
}
2828

html5/web/file/filesystem/filesystem.dart

+10-8
Original file line numberDiff line numberDiff line change
@@ -5,25 +5,26 @@
55
// This is a port of "Exploring the FileSystem APIs" to Dart.
66
// See: http://www.html5rocks.com/en/tutorials/file/filesystem/
77

8+
import 'dart:convert' show HtmlEscape;
89
import 'dart:html';
9-
import 'package:dart_samples/htmlescape.dart';
1010

1111
class FileSystemExample {
1212
FileSystem _filesystem;
1313
Element _fileList;
14+
HtmlEscape sanitizer = new HtmlEscape();
1415

1516
FileSystemExample() {
16-
_fileList = query('#example-list-fs-ul');
17+
_fileList = querySelector('#example-list-fs-ul');
1718

1819
window.requestFileSystem(1024 * 1024, persistent: false)
1920
.then(_requestFileSystemCallback, onError: _handleError);
2021
}
2122

2223
void _requestFileSystemCallback(FileSystem filesystem) {
2324
_filesystem = filesystem;
24-
query('#add-button').onClick.listen((e) => _addFiles());
25-
query('#list-button').onClick.listen((e) => _listFiles());
26-
query('#remove-button').onClick.listen((e) => _removeFiles());
25+
querySelector('#add-button').onClick.listen((e) => _addFiles());
26+
querySelector('#list-button').onClick.listen((e) => _listFiles());
27+
querySelector('#remove-button').onClick.listen((e) => _removeFiles());
2728
}
2829

2930
void _handleError(FileError e) {
@@ -48,7 +49,7 @@ class FileSystemExample {
4849
msg = 'Unknown Error';
4950
break;
5051
}
51-
query("#example-list-fs-ul").text = "Error: $msg";
52+
querySelector("#example-list-fs-ul").text = "Error: $msg";
5253
}
5354

5455
void _addFiles() {
@@ -72,7 +73,8 @@ class FileSystemExample {
7273
var img = entry.isDirectory ? '<img src="http://www.html5rocks.com/static/images/tutorials/icon-folder.gif">' :
7374
'<img src="http://www.html5rocks.com/static/images/tutorials/icon-file.gif">';
7475
var li = new Element.tag("li");
75-
li.innerHtml = "$img<span>${htmlEscape(entry.name)}</span>";
76+
77+
li.innerHtml = "$img<span>${sanitizer.convert(entry.name)}</span>";
7678
fragment.nodes.add(li);
7779
});
7880
_fileList.nodes.add(fragment);
@@ -96,4 +98,4 @@ class FileSystemExample {
9698

9799
void main() {
98100
new FileSystemExample();
99-
}
101+
}

0 commit comments

Comments
 (0)