Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build workflow #663

Open
WhitWaldo opened this issue Feb 28, 2025 · 0 comments
Open

Update build workflow #663

WhitWaldo opened this issue Feb 28, 2025 · 0 comments
Assignees
Labels
chores Admin related tasks
Milestone

Comments

@WhitWaldo
Copy link
Contributor

WhitWaldo commented Feb 28, 2025

The build workflow needs to be updated. If all unit and E2E tests don't pass successfully, neither the build nor build-dev workflows should be executed.

Further, today, the (production) build pipeline takes the version number out of package.json to use when publishing to NPM. This needs to be updated so it will use the tag version passed in from GitHub so this file doesn't perpetually need updating prior to a new release. Perhaps model after what the dev build pipeline does, because it had no problem producing RCs without updating package.json.

@WhitWaldo WhitWaldo added the area/tests Test cases related label Feb 28, 2025
@WhitWaldo WhitWaldo self-assigned this Feb 28, 2025
@WhitWaldo WhitWaldo added this to the v3.6.0 milestone Feb 28, 2025
@WhitWaldo WhitWaldo added chores Admin related tasks and removed area/tests Test cases related labels Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chores Admin related tasks
Projects
None yet
Development

No branches or pull requests

1 participant