Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.health.isHealthy() needs documentation on how to use and would expect this to have retries #576

Open
msfussell opened this issue Mar 2, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request pinned
Milestone

Comments

@msfussell
Copy link
Member

msfussell commented Mar 2, 2024

The SDKs have sidecar health status APIs

Expected Behavior

  1. The `client.health.isHealthy() has no documentation on how to use this API. Add to the docs here https://v1-13.docs.dapr.io/developing-applications/sdks/js/js-client/
  2. There are no retries on this API as far as I can tell, which does not make it useful. I would either have the Python approach which hides the API on client start (it checks for health) or have a retry like Java and .NET
  3. Also this does not see to check the healthx/outbound endpoint, instead does something different on the metadata endpoint. This should be consistent with the other APIs, including ideally in the name.

Actual Behavior

  1. No docs
    2)No retries to API
  2. Different impl from other SDKs
@dapr-bot
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned
Projects
Status: Needs Owner
Development

No branches or pull requests

5 participants