Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent error handling between communication protocol for state management #481

Open
SoTrx opened this issue Apr 25, 2023 · 3 comments
Labels

Comments

@SoTrx
Copy link
Contributor

SoTrx commented Apr 25, 2023

Expected Behavior

Whether you use HTTP or gRPC shouldn't matter for coding.

Actual Behavior

The save() method in the gRPC implementation throws an exception on failure, which is great
However, the same save() method in the HTTP implementation returns an object containing an error without actually throwing an exception.

Steps to Reproduce the Problem

You can see this in the code itself

Re-trowing the error in the HTTP implementation should fix this, and perhaps using the cause attribute on top of that to chain errors would also help with debugging.

I can help with this if needed.

@shubham1172 shubham1172 added the enhancement New feature or request label Apr 26, 2023
@SoTrx
Copy link
Contributor Author

SoTrx commented Apr 26, 2023

/assign

@dapr-bot
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale label Jun 25, 2023
@shubham1172
Copy link
Member

/keep-alive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants