Skip to content

Commit 87189ed

Browse files
Merge branch 'master' into 1566-setting-default-values-for-prop
2 parents 5957483 + 2787e4c commit 87189ed

File tree

4 files changed

+13
-5
lines changed

4 files changed

+13
-5
lines changed

sdk-tests/src/test/java/io/dapr/it/testcontainers/ContainerConstants.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,5 @@ public interface ContainerConstants {
77
String DAPR_PLACEMENT_IMAGE_TAG = DaprContainerConstants.DAPR_PLACEMENT_IMAGE_TAG;
88
String DAPR_SCHEDULER_IMAGE_TAG = DaprContainerConstants.DAPR_SCHEDULER_IMAGE_TAG;
99
String TOXI_PROXY_IMAGE_TAG = "ghcr.io/shopify/toxiproxy:2.5.0";
10+
String JDK_17_TEMURIN_JAMMY = "eclipse-temurin:17-jdk-jammy";
1011
}

sdk-tests/src/test/java/io/dapr/it/testcontainers/workflows/multiapp/WorkflowsMultiAppCallActivityIT.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
package io.dapr.it.testcontainers.workflows.multiapp;
1515

16+
import io.dapr.it.testcontainers.ContainerConstants;
1617
import io.dapr.testcontainers.Component;
1718
import io.dapr.testcontainers.DaprContainer;
1819
import io.dapr.testcontainers.DaprLogLevel;
@@ -113,7 +114,7 @@ public class WorkflowsMultiAppCallActivityIT {
113114

114115
// TestContainers for each app
115116
@Container
116-
private static GenericContainer<?> multiappWorker = new GenericContainer<>("openjdk:17-jdk-slim")
117+
private static GenericContainer<?> multiappWorker = new GenericContainer<>(ContainerConstants.JDK_17_TEMURIN_JAMMY)
117118
.withCopyFileToContainer(MountableFile.forHostPath("target"), "/app")
118119
.withWorkingDirectory("/app")
119120
.withCommand("java", "-cp", "test-classes:classes:dependency/*:*",
@@ -127,7 +128,7 @@ public class WorkflowsMultiAppCallActivityIT {
127128
.withLogConsumer(outputFrame -> System.out.println("MultiAppWorker: " + outputFrame.getUtf8String()));
128129

129130
@Container
130-
private final static GenericContainer<?> app2Worker = new GenericContainer<>("openjdk:17-jdk-slim")
131+
private final static GenericContainer<?> app2Worker = new GenericContainer<>(ContainerConstants.JDK_17_TEMURIN_JAMMY)
131132
.withCopyFileToContainer(MountableFile.forHostPath("target"), "/app")
132133
.withWorkingDirectory("/app")
133134
.withCommand("java", "-cp", "test-classes:classes:dependency/*:*",
@@ -141,7 +142,7 @@ public class WorkflowsMultiAppCallActivityIT {
141142
.withLogConsumer(outputFrame -> System.out.println("App2Worker: " + outputFrame.getUtf8String()));
142143

143144
@Container
144-
private final static GenericContainer<?> app3Worker = new GenericContainer<>("openjdk:17-jdk-slim")
145+
private final static GenericContainer<?> app3Worker = new GenericContainer<>(ContainerConstants.JDK_17_TEMURIN_JAMMY)
145146
.withCopyFileToContainer(MountableFile.forHostPath("target"), "/app")
146147
.withWorkingDirectory("/app")
147148
.withCommand("java", "-cp", "test-classes:classes:dependency/*:*",

spring-boot-examples/workflows/multi-app/orchestrator/src/test/java/io/dapr/springboot/examples/orchestrator/DaprTestContainersConfig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ public GenericContainer<?> workerOneContainer(Network daprNetwork,
123123
@Qualifier("workerOneDapr") DaprContainer workerOneDapr,
124124
DaprPlacementContainer daprPlacementContainer,
125125
DaprSchedulerContainer daprSchedulerContainer){
126-
return new GenericContainer<>("openjdk:17-jdk-slim")
126+
return new GenericContainer<>(DockerImages.JDK_17_TEMURIN_JAMMY)
127127
.withCopyFileToContainer(MountableFile.forHostPath("../worker-one/target"), "/app")
128128
.withWorkingDirectory("/app")
129129
.withCommand("java",
@@ -165,7 +165,7 @@ public GenericContainer<?> workerTwoContainer(Network daprNetwork,
165165
@Qualifier("workerTwoDapr") DaprContainer workerTwoDapr,
166166
DaprPlacementContainer daprPlacementContainer,
167167
DaprSchedulerContainer daprSchedulerContainer){
168-
return new GenericContainer<>("openjdk:17-jdk-slim")
168+
return new GenericContainer<>(DockerImages.JDK_17_TEMURIN_JAMMY)
169169
.withCopyFileToContainer(MountableFile.forHostPath("../worker-two/target"), "/app")
170170
.withWorkingDirectory("/app")
171171
.withCommand("java",
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
package io.dapr.springboot.examples.orchestrator;
2+
3+
public interface DockerImages {
4+
5+
String JDK_17_TEMURIN_JAMMY = "eclipse-temurin:17-jdk-jammy";
6+
}

0 commit comments

Comments
 (0)