Use transaction and script arguments instead of string templating #296
Description
Issue To Be Solved
This is likely an issue across most of Dapper's products, so this should be addressed wherever it is applicable.
Topshot and other Dapper apps should start using arguments for transactions and scripts and not string template them. All work by third parties to monitor activity on them is very very hard since they do this. It is not possible to get arguments to this https://www.flowscan.io/tx/0a869a6e007b43830887afb662923670d6a254ea6ba8358f3769dce938d23a51?tab=events for instance.
This also causes performance issues for the network since dapper is such a large user of Flow. Transactions with arguments are much easier to be optimized and executed quickly by the network.
Suggest A Solution
Use the versions of transactions in the repo that use arguments for the configurable variables in the transactions and no longer use string templating:
For example in destroy_moments
transaction(momentIDs: [UInt64]) {
instead of
transaction {
like it is in the linked file