Conversation
Add diagnostic about HTTPS_PROXY arg for Docker build Priority: 2 Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
ryon-jensen
previously approved these changes
Jul 23, 2025
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com> Doc-only: true
osalyk
approved these changes
Feb 9, 2026
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
osalyk
reviewed
Feb 20, 2026
| // Then a second PR submitted to comment out the @Library line, and when it | ||
| // is landed, both PR branches can be deleted. | ||
| //@Library(value='pipeline-lib@my_branch_name') _ | ||
| @Library(value='pipeline-lib@grom72/sre-3215') _ |
Contributor
There was a problem hiding this comment.
Don't forget to remove this before merging.
osalyk
previously approved these changes
Feb 20, 2026
ryon-jensen
previously approved these changes
Feb 20, 2026
| ret_str += ' --build-arg HTTPS_PROXY' + '="' + https_proxy + '"' | ||
| ret_str += ' --build-arg DAOS_HTTPS_PROXY' + '="' + https_proxy + '"' | ||
| } else { | ||
| println "WARNING: Missing DAOS_HTTPS_PROXY variable in Docker build arguments" |
Contributor
There was a problem hiding this comment.
What's the impact to the build if DAOS_HTTPS_PROXY doesn't exist? Does the build fail?
Contributor
Author
There was a problem hiding this comment.
What's the impact to the build if DAOS_HTTPS_PROXY doesn't exist? Does the build fail?
It will fail as it does not have access to external sources of packages (needed by docker build process)
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Contributor
Author
grom72
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add diagnostic about missing HTTPS_PROXY arg for Docker build
Remove requirement to provide the
HTTPS_PROXYenv variable from JenkinsTested by https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16619/3/
(https://github.com/daos-stack/daos/compare/grom72/sre-3215)
(daos-stack/daos#16619)