Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wLED backup issues with new wLED version. #73

Open
SirGoodenough opened this issue Sep 22, 2022 · 6 comments
Open

wLED backup issues with new wLED version. #73

SirGoodenough opened this issue Sep 22, 2022 · 6 comments

Comments

@SirGoodenough
Copy link

SirGoodenough commented Sep 22, 2022

I know you have MANY limitations dealing with wLED. Not here to ask for more function.
This is what I noticed today as I did a backup of a device with the latest release on it. It appeared to be an issue with the existing code.
This is the device that I backed up.

Screenshot_20220922_185313
Screenshot_20220922_190110

The back-up appears to be a success as reported by Tasmobackup.

After it does so, however, the reported version has not changed...

Screenshot_20220922_185541

As long as there is a backup there, it's all good. Just pointing it out as they probably changed some variable on you again.

@patrickdk77
Copy link
Collaborator

Ya, backups are failing. I did test this against 0.13.0-bx and 0.11 and I think 0.12
But testing it again now, using 0.13.1 and 0.13.3, all backups in wled seem to be broken.

If I click backup config or backup presets from the wled settings page, they also fail for me, so it doesn't look like I can fix this.

@devzwf
Copy link

devzwf commented Oct 17, 2022

i think that fixed
i can manually backup config and presets with no issue for the WebUi of wled

but TB still failed (sort of of) saying backup complete but no file in the backup dir.

@lensherm
Copy link

Confirming that I can successfully backup config and presets from the WLED GUI on the following versions:
0.13.3
0.13.1 SR fork

Clicking the Backup button on individual WLED devices in TasmoBackup 1.05.00 results in a "Backup completed successfully!" message, yet after this, no backup files are listed for these devices.

@patrick-blom
Copy link
Contributor

Can confirm the same behavior @lensherm described.

@patrickdk77
Copy link
Collaborator

Yes, I need to find time to retest this, for me the wled gui wasn't giving me backups, could have been anything that caused that issue, but it was stopping me from being able to reproduce this correctly, to find the real issue. I won't have time to look into this though till probably thanksgiving. Hope to put out a nice fresh release then fixing a few things.

@patrick-blom
Copy link
Contributor

I found the issue and created a quick fix.

Plz have a look at my PR: #82

Cheers Patrick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants