Fix size validation for OpenAI model in Art skill (PAI v2.1)#348
Closed
Azd325 wants to merge 1 commit into
Closed
Conversation
The validation was incorrectly falling through to REPLICATE_SIZES check for gpt-image-1 model, causing valid OpenAI sizes to be rejected. Changed the if-else-if chain to properly handle each model type: - gpt-image-1 now validates against OPENAI_SIZES only - nano-banana-pro validates against GEMINI_SIZES only - Other models validate against REPLICATE_SIZES This allows gpt-image-1 to accept its valid sizes (1024x1024, 1536x1024, 1024x1536) without incorrectly checking against Replicate's aspect ratio format.
|
thanks was about to do the same, you beat me :D thanks again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
The Art skill's
Generate.tstool was rejecting valid OpenAI image sizes (1536x1024, 1024x1536) with an "Invalid size" error.Root Cause
The size validation logic was falling through to check OpenAI sizes against Replicate's aspect ratio format, causing valid sizes to be rejected.
The Fix
Changed the validation from:
To proper if-else-if structure:
Testing Done
✅ Verified OpenAI model now works with all valid sizes: 1024x1024, 1536x1024, 1024x1536
✅ Tested image generation completes successfully
✅ Confirmed no impact on other models (nano-banana-pro, flux, nano-banana)
Example