Installer ships 39 hook scripts and registers 28; nothing compares the two inventories (follow-up to #1508)

[tzioup]

The installer ships 39 hook scripts and registers 28; nothing compares the two inventories (follow-up to #1508)

Structured for machine parsing: claims are atomic, and each carries the command that verifies it. Every command runs against a fresh clone of this repo — none depend on my machine, my install, or my configuration. Reproduction is at the bottom if you'd rather run it than read it.

Summary

InstallHooks.ts performs two operations and verifies each independently:

1. cpSync the entire payload hooks/ tree onto disk — verified by a file count (hookFiles vs hookFilesCopied).
2. Merge hooks/hooks.json into settings.json — verified by reporting added, skipped, events.

Both succeed. Neither is wrong. Nothing compares the set of files copied against the set of hooks registered. 39 hook scripts land on disk; 28 are named by the manifest merged beside them. The install reports success accurately, because "validated" here means "both operations completed," never "the things I copied are the things I registered."

Of the 11-hook difference, 8 are legitimately loaded via dispatcher imports. Three are unreachable: DriftReminder, PostToolObserver, and LoopDetector (whose only importer is PostToolObserver).

Doctor.ts --reconcile — which you shipped in v7.1.1 for exactly this, and which the same install run copies onto disk — reports all three correctly in under a second. The installer does not call it.

Claims and verification

Run from the root of a fresh clone.

C1 — the payload ships 39 hook scripts.

ls LifeOS/install/hooks/*.hook.ts LifeOS/install/hooks/*.hook.sh | wc -l
# 39

C2 — the manifest registers 28 distinct hooks.

grep -oE '[A-Za-z]+\.hook\.(ts|sh)' LifeOS/install/hooks/hooks.json | sort -u | wc -l
# 28

C3 — 11 shipped hooks are absent from the manifest.

comm -23 \
  <(ls LifeOS/install/hooks/*.hook.ts LifeOS/install/hooks/*.hook.sh | xargs -n1 basename | sort) \
  <(grep -oE '[A-Za-z]+\.hook\.(ts|sh)' LifeOS/install/hooks/hooks.json | sort -u)
# 11 lines

C4 — of those 11, two have no importer anywhere; they are unreachable by any path.

comm -23 \
  <(ls LifeOS/install/hooks/*.hook.ts LifeOS/install/hooks/*.hook.sh | xargs -n1 basename | sort) \
  <(grep -oE '[A-Za-z]+\.hook\.(ts|sh)' LifeOS/install/hooks/hooks.json | sort -u) \
| while read -r f; do b="${f%.hook.*}"
    grep -qlE "from \"\./$b\.hook\"" LifeOS/install/hooks/*.hook.ts 2>/dev/null || echo "UNWIRED: $f"
  done
# UNWIRED: DriftReminder.hook.ts
# UNWIRED: PostToolObserver.hook.ts

The other 8 resolve to PreToolGuard, StopGates, or MemoryTurnStart and are correctly dispatcher-loaded.

C5 — LoopDetector is dead transitively: its sole importer is PostToolObserver, which is itself unwired. C4's check misses this because it only tests one level; your reconciler does the transitive closure and catches it.

C6 — your own tool reports all three. Against an installed tree:

bun LIFEOS/TOOLS/Doctor.ts --reconcile
# { "unwired": ["LoopDetector.hook.ts", "DriftReminder.hook.ts", "PostToolObserver.hook.ts"], ... }

Output from a clean v7.1.1 install, today. This matches C4+C5 exactly.

C7 — Doctor.ts ships in the payload and is copied by the same install run.

ls LifeOS/install/LIFEOS/TOOLS/Doctor.ts

C8 — InstallHooks.ts never cross-checks the two inventories.
LifeOS/Tools/InstallHooks.ts — hookFiles is set at line 71 from the payload dir, hookFilesCopied at line 102 from the destination; added/skipped/events come from mergeHooks at line 80. The two are reported in the same JSON object (line 104) and never compared. No call to the reconciler appears in the file.

C9 — the shipped docs disagree with the shipped manifest. LifeOS/install/LIFEOS/DOCUMENTATION/Hooks/HookSystem.md:1562 states:

"the UserPromptSubmit chain is 6 hooks (PromptProcessing, SatisfactionCapture, ReminderRouter, DriftReminder, MemoryTurnStart, AlgorithmNudge)"

jq -r '.hooks.UserPromptSubmit[].hooks[].command' LifeOS/install/hooks/hooks.json
# 4 entries; DriftReminder and AlgorithmNudge absent

Same for HookSystem.md:322 (PostToolObserver on PostToolUse) and :22 (census of 30 registered; actual 28).

Why this wasn't caught

Not an oversight in the reconciler — it works. The gap is that --reconcile has exactly one automatic caller, LIFEOS/PULSE/modules/doctor.ts, which serves it to the Pulse System→Hooks page. Pulse is an à-la-carte component. On a Core install it never runs, so the reconciler's correct answer is never requested.

Impact

DriftReminder is named twice in LIFEOS_SYSTEM_PROMPT.md as the enforcement for voice/format drift, and HookSystem.md documents it as registered. It never executes. PostToolObserver is documented as the sync catch-all; loop/oscillation detection never executes.

Because these hooks never fire, they also produce no logs — so on a stock install their absence is silent. There is no error, no degraded mode, and no telemetry indicating anything is missing.

Suggested fix

One line in InstallHooks.ts: after --apply, shell Doctor.ts --reconcile and print unwired alongside the existing success report. The tool is already on disk at that point in the install — it was copied by the same run.

This would have surfaced these three hooks at install time, on every install, for every user, in the release that introduced the reconciler.

Happy to open the PR.

Reproduction

git clone https://github.com/danielmiessler/LifeOS && cd LifeOS
ls LifeOS/install/hooks/*.hook.ts LifeOS/install/hooks/*.hook.sh | wc -l   # 39
grep -oE '[A-Za-z]+\.hook\.(ts|sh)' LifeOS/install/hooks/hooks.json | sort -u | wc -l   # 28

Two numbers, one repo, no install required.

Scope

Verified against v7.1.1 on a clean install (second vanilla install; the first was archived to eliminate a legacy-content variable). C1–C5 and C7–C9 are properties of the repo tree and hold for any clone. C6 was run on my install; it depends on settings.json content and will differ on an install whose settings carry additional registrations.

[tzioup]

PR with the install-time fix: #1540

It shells the reconciler you already ship (Doctor.ts --reconcile) after --apply and folds unwired into the existing install report. No logic duplicated — your reconciler already does the transitive closure through dispatcher imports correctly, which my one-liner in C4 above does not (it misses LoopDetector).

On a clean payload into an empty config root it reports all three.

[tzioup]

Context: I was assessing whether LIFEOS/ALGORITHM/ could be adopted on its own by an install still on an older version — the doctrine is ~90 lines of markdown with no imports, so it's the most portable-looking thing in the project. This issue is what that assessment kept running into, so it seemed more useful to add here than to open something new.

The obstacle to a standalone adoption isn't the doctrine itself — it's that the teeth annotations (HOOK / CHECK / SELF) are exactly the part you need to trust when deciding what to carry across, and a few of them name machinery that isn't reachable in the payload.

The one that actually stopped us: claim 8 is annotated (HOOK: VerificationGate · CheckpointPerISC commits every [x]). VerificationGate is genuinely wired via StopGates and does block — no issue there. CheckpointPerISC reads an allowlist at ~/.claude/checkpoint-repos.txt (:33) that the release doesn't create, so the empty-allowlist early return at :170-174 fires and it's a no-op on a fresh install.

What made it feel like it belonged on this issue: when we went back to check whether the older version we were porting to had a working version to compare against, CheckpointPerISC was in the same position there — for a different reason. It shipped unregistered in v5.0.0. Same documented behaviour, two unrelated reasons for not happening, two majors apart. That's not really a hook bug; it's the thing your inventory cross-check is aimed at.

The four filed instances we found while looking (different component each time)

Issue	Reporter	Release	Shape
#1134	wojteksbt	v5.0.0	ISASync / CheckpointPerISC / ToolFailureTracker ship unregistered
#1254	edbizarro	Algorithm v6.3.0	same two described as active, not wired
#1510	bnkath2o	v7.1.1	DriftReminder / PostToolObserver / LoopDetector ship unregistered
#1524	jbmml	v7.1.1	ISA skill still consumes retired TheRouter signals

Each instance names a different component, so each one dedups cleanly against the last — which is probably why it reads as several unrelated small bugs rather than as one thing.

[danielmiessler]

Addressed via your PR #1540, which is now ported into source: install applies the merge, then shells the shipped reconciler and folds unwired[] into the install report, loud when Doctor.ts is missing. On the three specific hooks: they are registered from the maintainer's private user-level settings, which is why the shipped manifest doesn't carry them; whether DriftReminder joins the public default set is a release decision we're taking separately. The provenance/generalization ideas in your follow-up comment are noted and good, just bigger than this fix. Thanks for both the report and the patch.