I would like to contribute with a pull request

[kemosparc]

Hi,

I have downloaded jsoncons headers only and I was trying to integrate it into a WASM module. To be able to do that I needed to disable exceptions.

It should work out of the box but it gave me some compilation errors. After going through the code I discovered that a code ammendment is needed in file /include/jsoncons/reflect/json_conv_traits.hpp at line 76. It should look like that:

#if !defined(JSONCONS_NO_EXCEPTIONS)
JSONCONS_CATCH (const ser_error& ec)
{
return result_type(jsoncons::unexpect, ec.code());
}
#endif

Adding those macros disable the catch when exceptions are disabled !! although when exceptions are disabled the macro JSONCONS_CATCH (const ser_error& ec) resolves to "if (false)" yet the compiler complains about the ec.code() reporing that it is undefined.

I need this to be in place so when I clone the repo inside my docker image i do not have to modify it by hand. Another approach is to take a copy of this repo into my account but this will disallow me from getting further updates.

So kindly wither give me access to push my branch and create a pull request, or accomodate the fix in your master branch and letb me know to re-pull it.

Thanks,

[danielaparker]

Thanks for reporting this.

Statements inside JSONCONS_CATCH shouldn't make use of the exception argument, it looks like this one has crept in since the last time we tested this. You're welcome to submit a PR to change it to

JSONCONS_CATCH (const ser_error&)
{
    return result_type(jsoncons::unexpect, conv_errc::conversion_failed );
}

[kemosparc]

I am trying to push to a new branch with my nick name but I am not allowed:

git push origin kemosparc
ERROR: {"auth_status":"access_denied_to_user","body":"Permission to danielaparker/jsoncons.git denied to kemosparc."}

fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

[danielaparker]

You've clicked on New Pull Request from https://github.com/danielaparker/jsoncons/pulls?

[kemosparc]

Yes I need to have a branch with the updates so I can create the pull request with the diff.

On my local copy of the repo I created a new branch called "kemosparc" and I am trying to push it to git hub then create the pull request from kemosparc -> master.

The message above indicates that I do not have permission to push my branch on the repo ?! you have to give me access.

Is there any other way to create a pull request ?

Thanks,

[danielaparker]

You need to fork the repo (click fork on https://github.com/danielaparker/jsoncons), make your changes on kemosparc/jsoncons (on master), and then submit a PR to request that I take these changes back into danielaparker/jsoncons.

[kemosparc]

Oh, that is new to me, I did not know that I can do a pull request from a forked repo.

Today I learned a new thing :)

It is done, thanks Daniel.

Kairm.