Skip to content

Commit dff3e1f

Browse files
committed
Add MSVC trybot and CI back
Fixes chromium#267
1 parent 6cae793 commit dff3e1f

File tree

2 files changed

+18
-22
lines changed

2 files changed

+18
-22
lines changed

.github/workflows/ci.yml

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,15 @@ jobs:
1212
fail-fast: false
1313
matrix:
1414
config:
15-
# MSVC is broken: https://github.com/chromium/subspace/issues/267
16-
#- {
17-
# name: "Windows MSVC",
18-
# artifact: "Windows-MSVC.tar.xz",
19-
# os: windows-latest,
20-
# build_type: "Release",
21-
# cc: "cl",
22-
# cxx: "cl",
23-
# environment_script: "C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Auxiliary/Build/vcvars64.bat",
24-
# }
25-
15+
- {
16+
name: "Windows MSVC",
17+
artifact: "Windows-MSVC.tar.xz",
18+
os: windows-latest,
19+
build_type: "Release",
20+
cc: "cl",
21+
cxx: "cl",
22+
environment_script: "C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Auxiliary/Build/vcvars64.bat",
23+
}
2624
#- {
2725
# name: "Windows MinGW", artifact: "Windows-MinGW.tar.xz",
2826
# os: windows-latest,

.github/workflows/try.yml

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,15 @@ jobs:
1515
fail-fast: false
1616
matrix:
1717
config:
18-
# MSVC is broken: https://github.com/chromium/subspace/issues/267
19-
#- {
20-
# name: "Windows MSVC",
21-
# artifact: "Windows-MSVC.tar.xz",
22-
# os: windows-latest,
23-
# build_type: "Release",
24-
# cc: "cl",
25-
# cxx: "cl",
26-
# environment_script: "C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Auxiliary/Build/vcvars64.bat",
27-
# }
28-
18+
- {
19+
name: "Windows MSVC",
20+
artifact: "Windows-MSVC.tar.xz",
21+
os: windows-latest,
22+
build_type: "Release",
23+
cc: "cl",
24+
cxx: "cl",
25+
environment_script: "C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Auxiliary/Build/vcvars64.bat",
26+
}
2927
#- {
3028
# name: "Windows MinGW", artifact: "Windows-MinGW.tar.xz",
3129
# os: windows-latest,

0 commit comments

Comments
 (0)