Skip to content

Change even not functional #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KoenLav opened this issue Mar 22, 2016 · 2 comments
Open

Change even not functional #22

KoenLav opened this issue Mar 22, 2016 · 2 comments

Comments

@KoenLav
Copy link

KoenLav commented Mar 22, 2016

After removing the jQuery dependency the change event on selects is no longer fully functional (when using Materialize, or any other package which wraps selects, for that matter).

jQuery change will listen for any change (even programatically) on the original element, whereas pure Javascript change will only listen fire when a change is accompanied by a change of focus (which does not occur when a select is changed programatically).

http://stackoverflow.com/questions/7055729/onchange-event-not-fire-when-the-change-come-from-antoher-function

Suggested fix: allow jQuery to be used by setting addBinding)){ jQuery: true })

@dalgard
Copy link
Owner

dalgard commented Mar 27, 2016

I think a better fix would be triggering the change event manually inside the binding. What do you think?

@KoenLav
Copy link
Author

KoenLav commented Mar 27, 2016

Well it depends. If you want to loose jQuery as a dependency, which I understand, you also loose some functionality.

jQuery is pretty 'default' in Meteor, so I think most people would Epe expect it to be possible to use jQuery bindings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants