finish addressing #228

daler · Apr 9, 2024 · 175f421 · 175f421
1 parent cd01ff5
commit 175f421
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/gffutils/biopython_integration.py b/gffutils/biopython_integration.py
@@ -72,8 +72,8 @@ def from_seqfeature(s, **kwargs):
 
     # BioPython parses 1-based GenBank positions into 0-based for use within
     # Python.  We need to convert back to 1-based GFF format here.
-    start = s.location.start.position + 1
-    stop = s.location.end.position
+    start = s.location.start + 1
+    stop = s.location.end
     featuretype = s.type
     id = s.id
     attributes = dict(s.qualifiers)

diff --git a/gffutils/test/test_biopython_integration.py b/gffutils/test/test_biopython_integration.py
@@ -13,8 +13,8 @@ def test_roundtrip():
     feature.keep_order = True
     dialect = feature.dialect
     s = bp.to_seqfeature(feature)
-    assert s.location.start.position == feature.start - 1
-    assert s.location.end.position == feature.stop
+    assert s.location.start == feature.start - 1
+    assert s.location.end == feature.stop
     assert s.id == feature.id
     f = bp.from_seqfeature(s, dialect=dialect, keep_order=True)
     assert feature == f