Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis Ci: This build should fail but exit with 0 #12

Open
vergissberlin opened this issue Jun 19, 2014 · 3 comments
Open

Travis Ci: This build should fail but exit with 0 #12

vergissberlin opened this issue Jun 19, 2014 · 3 comments
Assignees
Labels

Comments

@vergissberlin
Copy link

Environment

  • DalekJS version: DalekJS CLI Tools Version: 0.0.4, DalekJS local install: 0.0.8
  • Operating System: Linux, Travis CI
  • Running Browser: PhantomJS
  • OS: linux unknown 64bit
  • Browser Version: 1.9.7

What

✘ TEST - "Fail test" FAILED
0/1 assertions passed. Elapsed Time: 0.42 sec 
The command "dalek tests/failTest.js" exited with 0.

As you can see in the log file, the test is failed. However dalek returns the status 0. Therefore, in Travis CI lit the green light.
The standard Unix exit code of "0" means the build passed; everything else is treated as failure.

Where

The Build: https://travis-ci.org/vergissberlin/dalekjs-travisci/builds/27998721

Idea

That might solve the problem:

process.exit(exitCode);

Thank you,
André

@asciidisco asciidisco added bug and removed bug labels Jun 28, 2014
@asciidisco asciidisco self-assigned this Jun 28, 2014
@asciidisco
Copy link
Member

Thanks for the detailed report. We will try to take care of this asap.

@vergissberlin
Copy link
Author

**Wohoo.**Hopefully I understand one day enough of your code, to fix it by myself. ;-)

@JGVB
Copy link

JGVB commented Apr 22, 2018

+1 adding "| xcpretty --test --color" to the end of an xcode build causes this issue. Seems like this is a workaround: https://groups.google.com/forum/#!msg/travis-ci/JtC4WiCMA0w/9PduHO3FOT8J

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants