Merge pull request kubernetes#804 from aleksandra-malinowska/unremovable-error-msg

aleksandra-malinowska · web-flow · commit 002eee46340e · 2018-04-18T17:38:52.000+02:00
Rephrase unremovable node warning
diff --git a/cluster-autoscaler/core/scale_down.go b/cluster-autoscaler/core/scale_down.go
@@ -172,7 +172,7 @@ func (sd *ScaleDown) UpdateUnneededNodes(
 	}
 	skipped := len(nodesToCheck) - len(filteredNodesToCheck)
 	if skipped > 0 {
-		glog.V(1).Infof("Scale-down calculation: ignoring %v nodes, that were unremovable in the last %v", skipped, UnremovableNodeRecheckTimeout)
+		glog.V(1).Infof("Scale-down calculation: ignoring %v nodes unremovable in the last %v", skipped, UnremovableNodeRecheckTimeout)
 	}
 
 	// Phase1 - look at the nodes utilization. Calculate the utilization
@@ -291,7 +291,7 @@ func (sd *ScaleDown) UpdateUnneededNodes(
 		for _, node := range unremovable {
 			sd.unremovableNodes[node.Name] = unremovableTimeout
 		}
-		glog.V(1).Infof("%v nodes found unremovable in simulation, will re-check them at %v", len(unremovable), unremovableTimeout)
+		glog.V(1).Infof("%v nodes found to be unremovable in simulation, will re-check them at %v", len(unremovable), unremovableTimeout)
 	}
 
 	// Update state and metrics

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,7 @@ func (sd *ScaleDown) UpdateUnneededNodes(`
`172`	`172`	`}`
`173`	`173`	`skipped := len(nodesToCheck) - len(filteredNodesToCheck)`
`174`	`174`	`if skipped > 0 {`
`175`		`- glog.V(1).Infof("Scale-down calculation: ignoring %v nodes, that were unremovable in the last %v", skipped, UnremovableNodeRecheckTimeout)`
	`175`	`+ glog.V(1).Infof("Scale-down calculation: ignoring %v nodes unremovable in the last %v", skipped, UnremovableNodeRecheckTimeout)`
`176`	`176`	`}`
`177`	`177`
`178`	`178`	`// Phase1 - look at the nodes utilization. Calculate the utilization`
`@@ -291,7 +291,7 @@ func (sd *ScaleDown) UpdateUnneededNodes(`
`291`	`291`	`for _, node := range unremovable {`
`292`	`292`	`sd.unremovableNodes[node.Name] = unremovableTimeout`
`293`	`293`	`}`
`294`		`- glog.V(1).Infof("%v nodes found unremovable in simulation, will re-check them at %v", len(unremovable), unremovableTimeout)`
	`294`	`+ glog.V(1).Infof("%v nodes found to be unremovable in simulation, will re-check them at %v", len(unremovable), unremovableTimeout)`
`295`	`295`	`}`
`296`	`296`
`297`	`297`	`// Update state and metrics`