-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AutomationCondition API migration guide #26223
Comments
I have the same question. I was previously using |
Thanks for reporting this. We've realized that, while automation conditions are a good replacement for the most common use case of There is a migration guide from auto-materialize policies to automation conditions, but it unfortunately doesn't cover multi-asset sensors. |
Thanks for the the answer and the reactivity 🙏 |
Resolves #26223 ## Summary & Motivation `@multi_asset_sensor` was deprecated with a message saying to use `AutomationCondition`, but `AutomationCondition` cannot cover all of `@multi_asset_sensor` uses cases (like running jobs), as discussed in #26223. ## Changelog Deprecation of `@multi_asset_sensor` has been rolled back.
I just spent the best part of a day trying to work out what I was missing, and this was it. Could you update the docs to explain that this is not supported? Or at least the bot? Also, is there something in the works that will have the declarative automation system support this? |
Can you clarify? This issue was about the deprecation of multi-asset sensors, but we reversed their deprecation. |
What's the issue?
I'm trying to migrate sensors from Dagster 1.7.4 to 1.9.2.
As asked by the framework some entities are deprecated, and it is the case of
@multi_asset_sensor
, saying that we should useAutomationConditions
instead :@deprecated(breaking_version="2.0.0", additional_warn_text="use `AutomationConditions` instead")
I don't find the documentation very clear and there is no migration guide (I think it should be a migration guide as the way we implement things change totally).
I would want to migrate the following code to the one using AutomationConditions API :
The documentation says here : https://docs.dagster.io/concepts/automation#selecting-a-method, that in the case above, we should choose https://docs.dagster.io/concepts/partitions-schedules-sensors/asset-sensors but the deprecation decorator shows that we should use AutomationConditions). Who is right and how to handle my use case if I have to use AutomationCondition ? How would you do ?
What did you expect to happen?
I expect the documentation to be clearer with some examples showing how to migrate from
@multi_asset_sensor
to AutomationConditions API. Maybe with some example with DBT for example and how to work with job triggering using AutomationConditions if the deprecation message is true. Otherwise specify that we should use assets_sensors as above.How to reproduce?
No response
Dagster version
dagster, version 1.9.2
Deployment type
Other Docker-based deployment
Deployment details
No response
Additional information
No response
Message from the maintainers
Impacted by this issue? Give it a 👍! We factor engagement into prioritization.
By submitting this issue, you agree to follow Dagster's Code of Conduct.
The text was updated successfully, but these errors were encountered: