fix: register the Client frontage when it is there, skip it when it is not

The previous commit stopped the fatal by deleting the reference. That
half was right — Core\Front\Client\Boot was extracted to its own package
and an application without it fataled during Application::configure().

But the other half was wrong, and worse. The client package declares no
providers for Laravel's package discovery, only "dont-discover", so this
aggregate is the ONLY thing that registers the Client frontage. Verified
against a live application: Core\Front\Client\Boot resolves from
vendor/dappcore/client, is REGISTERED at runtime, and gets there through
this list and nothing else. Dropping the line trades a loud failure for a
silent one — an application that boots cleanly and has quietly lost its
customer dashboard.

Registered conditionally instead, in both the provider list and
middleware(), so it works installed and uninstalled.

The regression test kept its "does not fatal without the package" case
and gained the case that was missing: with the package present, the
frontage is actually registered. That one skips where the package is
absent, which is this repo, and is the half that would have caught the
mistake.

448 pre-existing failures unchanged either side of this commit.

Co-Authored-By: Virgil <virgil@lethean.io>

Author: Snider

src/Core/Front/Boot.php

@@ -31,13 +31,20 @@
  *   Api        - HTTP → JSON (REST API)                  — php-api
  *   Mcp        - HTTP → JSON-RPC (MCP protocol)           — php-mcp
  *
- * Client\Boot lived here until it was extracted to the standalone
- * php-client package (see git history: "refactor: extract Service +
- * Client to standalone packages"). The extraction deleted
- * src/Core/Front/Client/ but left this class still hard-referencing
- * Client\Boot in both $providers and middleware() — a class that no
- * longer exists in this repo — which fataled Application::configure()
- * for every consuming app, not just ones missing php-client.
+ * Client\Boot lived here until it was extracted to the standalone client
+ * package. The extraction deleted src/Core/Front/Client/ but left this
+ * class hard-referencing Client\Boot in both $providers and middleware(),
+ * so an application without that package fataled during
+ * Application::configure() on a class that is no longer here.
+ *
+ * It cannot simply be dropped either. The client package declares no
+ * providers for Laravel's package discovery — only "dont-discover" — so
+ * this list is the ONLY thing that registers the Client frontage.
+ * Removing the line stops the fatal and silently takes the dashboard with
+ * it, which is the worse failure of the two: an application that boots
+ * fine and has quietly lost a surface.
+ *
+ * So it is registered when it is installed, and skipped when it is not.
  */
 class Boot extends AggregateServiceProvider
 {
@@ -49,6 +56,15 @@ class Boot extends AggregateServiceProvider
         Components\Boot::class,
     ];
 
+    public function register(): void
+    {
+        if (class_exists(Client\Boot::class)) {
+            $this->providers[] = Client\Boot::class;
+        }
+
+        parent::register();
+    }
+
     /**
      * Configure HTTP middleware - delegates to each HTTP frontage.
      * Stdio has no HTTP middleware (different transport).
@@ -58,6 +74,13 @@ public static function middleware(Middleware $middleware): void
         Web\Boot::middleware($middleware);
         Admin\Boot::middleware($middleware);
 
+        // Same reason as the provider list above: present when the client
+        // package is installed, absent when it is not, and its middleware
+        // group has to follow it either way.
+        if (class_exists(Client\Boot::class)) {
+            Client\Boot::middleware($middleware);
+        }
+
         // API and MCP groups — inlined because middleware() runs during
         // Application::configure(), before package providers load.
         // Packages add their own aliases during boot via lifecycle events.

tests/Feature/FrontBootMiddlewareTest.php

@@ -32,11 +32,29 @@ public function test_front_boot_middleware_does_not_reference_the_deleted_client
         $this->assertTrue(true);
     }
 
-    public function test_front_boot_aggregate_providers_do_not_reference_the_deleted_client_frontage(): void
+    public function test_front_boot_aggregate_providers_do_not_hard_reference_the_client_frontage(): void
     {
         $ref = new \ReflectionClass(Boot::class);
         $providers = $ref->getDefaultProperties()['providers'];
 
-        $this->assertNotContains('Core\Front\Client\Boot', $providers);
+        $this->assertNotContains('Core\\Front\\Client\\Boot', $providers);
+    }
+
+    public function test_front_boot_registers_the_client_frontage_when_the_package_is_installed(): void
+    {
+        // The other half, and the one that matters more. The client package
+        // declares no providers for Laravel's package discovery, so this
+        // aggregate is the ONLY thing that registers the Client frontage —
+        // dropping the reference to stop the fatal would take the dashboard
+        // with it silently, in every application that has the package.
+        if (! class_exists(\Core\Front\Client\Boot::class)) {
+            $this->markTestSkipped('client package not installed in this checkout');
+        }
+
+        $boot = new Boot($this->app);
+        $boot->register();
+
+        $ref = new \ReflectionProperty($boot, 'providers');
+        $this->assertContains(\Core\Front\Client\Boot::class, $ref->getValue($boot));
     }
 }