Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode for OSS Licenses Webview #49

Open
czlucius opened this issue Jul 25, 2022 · 8 comments
Open

Dark mode for OSS Licenses Webview #49

czlucius opened this issue Jul 25, 2022 · 8 comments

Comments

@czlucius
Copy link
Owner

https://joebirch.co/android/enabling-dark-theme-in-android-webviews/

@gauravkhuperkar
Copy link

IntroActivity(On boarding screen displayed for first time after installing an app) also need support for dark mode.

@czlucius
Copy link
Owner Author

There is no IntroActivity

@czlucius
Copy link
Owner Author

czlucius commented Oct 29, 2022

I think you were referring to the Android 12 splash screen?
That's a built in feature of Android.

@gauravkhuperkar
Copy link

gauravkhuperkar commented Oct 31, 2022

Hi @czlucius thanks for quick response. Please find the attched the video of screen -

whilte_onbaording_screen_in_dark_mode.mov

Also, please have a look at this PR I raised for OSS license webview dialog's dark mode supporthttps://github.com//pull/55
Thank you

@czlucius
Copy link
Owner Author

czlucius commented Nov 1, 2022

Hi @czlucius thanks for quick response. Please find the attched the video of screen -
whilte_onbaording_screen_in_dark_mode.mov

Also, please have a look at this PR I raised for OSS license webview dialog's dark mode supporthttps://github.com//pull/55 Thank you

I see. I must have missed out the onboarding screen (CSOnboarding). I use a library for this, do you want to go work on it?

@hhugoac
Copy link
Contributor

hhugoac commented Jul 17, 2023

Is this issue still open I want to collaborate?

@czlucius
Copy link
Owner Author

Sure
Can you take a look at the PR?

@czlucius
Copy link
Owner Author

#55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants