feat(network): configurable onboarding AP name — branding belongs to the app

WiFiManager(ap_name=...) sets the setup portal's SSID base; the library
keeps only the uniqueness tail (MAC-derived on hardware, -DEV off-device)
so two un-onboarded boxes never broadcast identical SSIDs. Default stays
the generic "WifiManager-" prefix — deliberately not a product name; no
app brand is hardwired in the library. Tests pin both: the generic
default and an app brand flowing through. 826 pass.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EVjnTZLoYtSvBRDuHCLhfP

Author: czei

src/scrollkit/network/wifi_manager.py

@@ -47,21 +47,29 @@ class WiFiManager:
     Manages WiFi connections for the application
     """
 
-    def __init__(self, settings_manager):
+    def __init__(self, settings_manager, ap_name=None):
         """
         Initialize the WiFi manager
-        
+
         Args:
             settings_manager: The settings manager
+            ap_name: Brand name for the setup-portal access point. The SSID a
+                customer sees while onboarding is ``"<ap_name>-<tail>"`` where
+                the tail is a short MAC-derived suffix (kept library-side so two
+                un-onboarded boxes in one home never broadcast identical SSIDs).
+                Apps SHOULD pass their product name — the default is the
+                generic ``WifiManager`` prefix, deliberately not a product name
+                (branding belongs to the app, never hardwired here).
         """
         self.settings_manager = settings_manager
+        self._ap_base = ap_name or "WifiManager"
         self.ssid, self.password = self._resolve_credentials()
         self.is_connected = False
         self.wifi_client = None
         self.ap_enabled = False
 
         # Development mode values
-        self.AP_SSID = "WifiManager_DEV"
+        self.AP_SSID = self._ap_base + "-DEV"
         self.AP_PASSWORD = "password"
 
         try:
@@ -72,10 +80,10 @@ def __init__(self, settings_manager):
                 self.wifi = None
                 self.HAS_WIFI = False
                 # Set dummy values for development
-                self.AP_SSID = "WifiManager_DEV"
+                self.AP_SSID = self._ap_base + "-DEV"
                 self.AP_PASSWORD = "password"
                 return
-                
+
             # Try to import CircuitPython specific modules
             import wifi
             self.wifi = wifi
@@ -84,7 +92,7 @@ def __init__(self, settings_manager):
             mac_ap = ' '.join([hex(i) for i in self.wifi.radio.mac_address_ap])
             mac_ap = mac_ap.replace('0x', '').replace(' ', '').upper()
             # access point settings
-            self.AP_SSID = "WifiManager_" + mac_ap[5:10] + mac_ap[1:2]
+            self.AP_SSID = self._ap_base + "-" + mac_ap[5:10] + mac_ap[1:2]
             self.AP_PASSWORD = "password"
             self.AP_AUTHMODES = [self.wifi.AuthMode.WPA2, self.wifi.AuthMode.PSK]
 

src/scrollkit/web/wifi_setup.py

@@ -7,7 +7,8 @@
 1. The device can't join Wi-Fi (no/wrong credentials), so the app calls
    ``WiFiManager.run_setup_portal(display=...)`` — usually right after a
    failed ``connect()``.
-2. The device starts its own access point (``WifiManager_XXXX``) and shows
+2. The device starts its own access point (named by the app via
+   ``WiFiManager(ap_name=...)``, e.g. ``ThemeParkWaits-XXXX``) and shows
    join instructions on the LED panel.
 3. The user's phone joins that AP and opens ``http://192.168.4.1``: a page
    with the scanned nearby networks (signal bars), a manual-SSID field, and

test/unit/network/test_wifi_manager.py

@@ -39,7 +39,9 @@ def test_initialization_with_wifi(self):
                     assert wifi_manager.ssid == 'TestSSID'
                     assert wifi_manager.password == 'TestPassword'
                     assert wifi_manager.is_connected is False
-                    assert "WifiManager_" in wifi_manager.AP_SSID
+                    # Hyphen separator since ap_name became configurable:
+                    # "<base>-<MAC tail>" (base defaults to WifiManager).
+                    assert "WifiManager-" in wifi_manager.AP_SSID
 
     def test_initialization_without_wifi(self):
         """Test initialization without WiFi module available"""
@@ -359,4 +361,24 @@ async def test_returns_false_when_nothing_saved(self):
         portal_instance.run = AsyncMock(return_value=False)
         with patch("scrollkit.web.wifi_setup.WiFiSetupPortal",
                    MagicMock(return_value=portal_instance)):
-            assert await wm.run_setup_portal() is False
+            assert await wm.run_setup_portal() is False
+
+class TestAccessPointNaming:
+    """The onboarding AP's SSID base is per-app configuration (ap_name), never a
+    product name hardwired in the library. The library owns only the uniqueness
+    tail (MAC-derived on hardware, -DEV off-device)."""
+
+    def _make(self, **kw):
+        mock_sm = MagicMock()
+        with patch('scrollkit.network.wifi_manager.load_credentials') as lc:
+            lc.return_value = ('TestSSID', 'TestPassword')
+            return WiFiManager(mock_sm, **kw)
+
+    def test_default_base_is_generic(self):
+        wm = self._make()
+        assert wm.AP_SSID.startswith("WifiManager-")
+        assert "ThemeParkWaits" not in wm.AP_SSID     # no app brand in the library
+
+    def test_app_brand_flows_through(self):
+        wm = self._make(ap_name="ThemeParkWaits")
+        assert wm.AP_SSID.startswith("ThemeParkWaits-")