Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper tracking of idCounter #6

Open
bdemchak opened this issue Aug 17, 2016 · 0 comments
Open

Improper tracking of idCounter #6

bdemchak opened this issue Aug 17, 2016 · 0 comments

Comments

@bdemchak
Copy link

The idCounter field of metadata is required for all aspects that create IDs (e.g., @id).

The correct value is the largest value of any ID in the aspect, including all previous versions of the aspect.

This is easy enough to calculate by remembering the idCounter that's read from NDEx, knowing the highest @id written to a new version of the aspect, and then taking the max(oldIDCounter, @id). However, this requires that idCounter be saved for all affected aspects that are read.

I don't think this has come up before, but it's useful to get out of the way now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant