Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove use of @cypress/commit-message-install #909

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

MikeMcC399
Copy link
Collaborator

Issue

The AppVeyor workflow, which runs CI under Windows, logs multiple deprecation messages, including:

npm i -g @cypress/commit-message-install @bahmutov/print-env
npm warn deprecated [email protected]: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm warn deprecated @octokit/[email protected]: '@octokit/app' will be repurposed in future. Use '@octokit/auth-app' instead
commit-message-install --else "npm ci"
(node:3700) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
run-if npm run cy:version
(node:1692) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

Analysis

Each of the deprecations comes from @cypress/[email protected] (current latest), released in Apr 2020 used in the workflow appveyor.yml:

$ npm ls debug
└─┬ @cypress/[email protected]
  ├─┬ @cypress/[email protected]
  │ └── [email protected] deduped
  └── [email protected]
$ npm ls @octokit/app
└─┬ @cypress/[email protected]
  └─┬ @cypress/[email protected]
    └── @octokit/[email protected]
$ npx commit-message-install
(node:4685) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
$ NODE_OPTIONS='--trace-deprecation' npx commit-message-install
(node:4706) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
    at node:punycode:3:9
    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:399:7)
    at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/realm:338:10)
    at loadBuiltinModule (node:internal/modules/helpers:114:7)
    at Function._load (node:internal/modules/cjs/loader:1100:17)
    at TracingChannel.traceSync (node:diagnostics_channel:315:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:218:24)
    at Module.require (node:internal/modules/cjs/loader:1340:12)
    at require (node:internal/modules/helpers:141:16)
    at Object.<anonymous> (/home/mike/github/commit-message-install-test/node_modules/whatwg-url/lib/url-state-machine.js:2:18)
$ npm ls whatwg-url
└─┬ @cypress/[email protected]
  └─┬ @cypress/[email protected]
    └─┬ @octokit/[email protected]
      └─┬ @octokit/[email protected]
        └─┬ [email protected]
          └── [email protected]

@cypress/commit-message-install is only used in the appveyor.yml workflow. The functionality of @cypress/commit-message-install to install a package using instructions hidden in a commit message is unused.

Change

Remove the use of @cypress/commit-message-install in the appveyor.yml workflow. This includes removal of commands using:

commit-message-install
run-if

Verification

Confirm that the AppVeyor workflow does not contain the deprecation messages mentioned above.

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399
Copy link
Collaborator Author

@MikeMcC399
Copy link
Collaborator Author

All CI workflows are successful

@MikeMcC399 MikeMcC399 marked this pull request as ready for review November 18, 2024 14:12
@mschile mschile removed the request for review from AtofStryker November 18, 2024 15:11
@mschile mschile merged commit d20f273 into cypress-io:master Nov 18, 2024
10 checks passed
@MikeMcC399 MikeMcC399 deleted the remove/commit-message-install branch November 18, 2024 15:19
@cypress-app-bot
Copy link
Collaborator

🎉 This PR is included in version 3.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants