Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: convert linux tests for Node.js 20 #859

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Jul 14, 2024

Issue

The .circleci/config.yml workflow shows multiple EBADENGINE warnings.

The linux-build jobs in the workflows section are currently running under the Node.js default v18.16.1 from the Cypress CircleCI Orb. They need to run under Node.js 20.x to be compatible with currently configured dependencies.

Change

  • Move the linux-build jobs in the workflows section to the jobs section
  • Convert the jobs from using the Cypress Circle CI Orb job cypress/run to use instead the Cypress Circle CI Orb command cypress/run-tests.
  • Add the following to the moved jobs:
    executor:
      name: cypress/default
      node-version: '20.13.1'
  • Rename the jobs to align to the Windows and Mac jobs

@cypress-app-bot
Copy link
Collaborator

@jennifer-shehane jennifer-shehane merged commit 006d869 into cypress-io:master Jul 15, 2024
13 checks passed
@MikeMcC399 MikeMcC399 deleted the ci/linux-to-node-20 branch July 16, 2024 06:39
@cypress-app-bot
Copy link
Collaborator

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CircleCI bad engine warnings linux-build: node ^18.18.0 required
3 participants