Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): update engines to min node.js 18 #727

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Aug 24, 2023

BREAKING CHANGE:

DO NOT MERGE UNTIL

This PR updates the engines section in package.json to

  "engines": {
    "node": "^18.0.0 || >=20.0.0"
  }

Also .node-version is updated to 20 as a recommendation for the currently optimal Node.js version when cloning and running the repo for demonstration purposes. This does not restrict the repo from being used with any other Node.js version.

Background

package.json

currently lists

  "engines": {
    "node": "^14.0.0 || ^16.0.0 || >=18.0.0"
  }

as supported Node.js versions. This is no longer in line with the Node.js release schedule:

Node.js 14 passed into end-of-life status on Apr 30, 2023
Node.js 19 passed into end-of-life status on Jun 1, 2023
Node.js 20 was released on Apr 18, 2023
Node.js 16 passed into end-of-life status on Sep 11, 2023

Additionally the official minimum version for Cypress is now Node.js 18.x according to Getting Started > Installing Cypress > Node.js.

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399

This comment was marked as resolved.

@MikeMcC399 MikeMcC399 force-pushed the update/engines-min-18 branch 2 times, most recently from 005ab41 to a199229 Compare September 11, 2023 14:17
@MikeMcC399 MikeMcC399 force-pushed the update/engines-min-18 branch from a199229 to 29cb629 Compare September 11, 2023 16:35
@MikeMcC399 MikeMcC399 marked this pull request as ready for review September 11, 2023 16:39
@MikeMcC399

This comment was marked as resolved.

BREAKING CHANGE: requires minimum Node.js 18
@MikeMcC399 MikeMcC399 force-pushed the update/engines-min-18 branch from 29cb629 to a877f33 Compare September 11, 2023 16:58
@MikeMcC399

This comment was marked as resolved.

@nagash77 nagash77 merged commit f4e1a84 into cypress-io:master Sep 11, 2023
1 check passed
@cypress-app-bot
Copy link
Collaborator

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MikeMcC399 MikeMcC399 deleted the update/engines-min-18 branch September 11, 2023 17:34
MikeMcC399 added a commit to MikeMcC399/cypress-example-kitchensink that referenced this pull request Jan 16, 2024
BREAKING CHANGE: requires minimum Node.js 18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package.json engines lists Node.js 14 in end-of-life status
3 participants