ci: add eslint cypress/recommended #666
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an enhancement to the CI process of the repository. It adds the eslint-plugin-cypress > Recommended configuration to the set of rules which are checked.
Change
The .eslintrc ESLint configuration file has the following configuration option added:
Additionally, and pending resolution of issue #661, the eslint rule
cypress/unsafe-to-chain-command
from eslint-plugin-cypress: Rules is disabled:PR #662 already disabled the eslint rule
cypress/no-unnecessary-waiting
from eslint-plugin-cypress: Rules in the following tests to prevent the rule being applied where it did not fit:Benefit
Linting against the set of rules defined by eslint-plugin-cypress > Recommended configuration ensures that the Cypress examples adhere to a documented set of Cypress standard rules. This retains the on-going quality of the examples provided and their ease-of-use.
Verification
Execute:
and confirm that no errors are reported.
References