Repository navigation
Commit 2cae328
authored
feat(SelectQuery): refine Psalm integer types on query bounds (#257)
Express numeric bounds via Psalm types so static analysis flags invalid values at call sites:
- runChunks() chunk size as int<1, max> (a non-positive value never advances the offset and spins in an endless loop);
- getLimit() / getOffset() as int<0, max>|null;
- count() as int<0, max> (a row count is never negative).
Also drop the redundant `psalm-` prefix from the existing non-empty-string column/method hints: plain `@param` advanced types are now broadly supported (Psalm, PHPStan, PhpStorm).
Return-type refinements only; LessSpecificReturnStatement / MoreSpecificReturnType are already suppressed project-wide, and setter params are left intact to preserve the PaginableInterface contract.1 parent 38c3403 commit 2cae328
1 file changed
Lines changed: 17 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
255 | 255 | | |
256 | 256 | | |
257 | 257 | | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
258 | 261 | | |
259 | 262 | | |
260 | 263 | | |
| |||
271 | 274 | | |
272 | 275 | | |
273 | 276 | | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
274 | 280 | | |
275 | 281 | | |
276 | 282 | | |
| |||
294 | 300 | | |
295 | 301 | | |
296 | 302 | | |
| 303 | + | |
| 304 | + | |
297 | 305 | | |
298 | 306 | | |
299 | 307 | | |
| |||
324 | 332 | | |
325 | 333 | | |
326 | 334 | | |
327 | | - | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
328 | 338 | | |
329 | 339 | | |
330 | 340 | | |
| |||
346 | 356 | | |
347 | 357 | | |
348 | 358 | | |
349 | | - | |
| 359 | + | |
350 | 360 | | |
351 | 361 | | |
352 | 362 | | |
353 | 363 | | |
354 | 364 | | |
355 | 365 | | |
356 | 366 | | |
357 | | - | |
| 367 | + | |
358 | 368 | | |
359 | 369 | | |
360 | 370 | | |
361 | 371 | | |
362 | 372 | | |
363 | 373 | | |
364 | 374 | | |
365 | | - | |
| 375 | + | |
366 | 376 | | |
367 | 377 | | |
368 | 378 | | |
369 | 379 | | |
370 | 380 | | |
371 | 381 | | |
372 | 382 | | |
373 | | - | |
| 383 | + | |
374 | 384 | | |
375 | 385 | | |
376 | 386 | | |
| |||
436 | 446 | | |
437 | 447 | | |
438 | 448 | | |
439 | | - | |
440 | | - | |
| 449 | + | |
| 450 | + | |
441 | 451 | | |
442 | 452 | | |
443 | 453 | | |
| |||
0 commit comments