Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discussion: using vertx-web router #3

Open
gjesse opened this issue Apr 11, 2016 · 4 comments
Open

discussion: using vertx-web router #3

gjesse opened this issue Apr 11, 2016 · 4 comments

Comments

@gjesse
Copy link

gjesse commented Apr 11, 2016

Hi, I started playing around with this code today, but quickly hit a limitation in that the router provided doesn't support path parameters. with some digging & poking, I ended up with this: https://github.com/gjesse/vertx-kotlin-router, which provides a similar interface but delegates to the standard vertx router. I'm wondering if you'd be amenable to swapping out the existing router implementation with something like what I've got? If so i can work up a proper PR with tests,etc.

@cy6erGn0m
Copy link
Owner

yes, I was thinking about extending bindings to support vertx-web as well. You are welcome to make PR ;)

@gjesse
Copy link
Author

gjesse commented Apr 11, 2016

do you want to keep the barebones router around too, or scrap it?

@cy6erGn0m
Copy link
Owner

@gjesse you could use different package for now but you don't need to be compatible with old router

@gjesse
Copy link
Author

gjesse commented Apr 14, 2016

Ok. Some things have changed & so I don't know when i might be able to get around to this now, but i will attempt to if I'm able.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants