Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CustomerIORouteObserver for optimized route tracking #88

Closed
wants to merge 1 commit into from

Conversation

AristideVB
Copy link

Summary

This PR introduces CustomerIORouteObserver, a route observer that automatically tracks screen views and reports them to Customer.io. The observer integrates seamlessly with GoRouter or MaterialApp, thus eliminating the need for manual tracking logic.

Changes

  • Implemented CustomerIORouteObserver that extends NavigatorObserver.
  • Integrated the observer with GoRouter.
  • Removed manual route tracking and listeners.

This PR aims to address Issue #87

@Shahroz16
Copy link
Collaborator

The PR was very valuable, thank you for creating it. They will be bundled up with some of the other changes in the pipeline, that are going to affect the public-facing APIs.

@Shahroz16 Shahroz16 closed this Aug 26, 2024
@AristideVB
Copy link
Author

Thanks @Shahroz16 looking forward, for this update ? Why not merge my PR thought ? If you are going to use the code ? 🙂

(Or suggest edits if needed)

@Shahroz16
Copy link
Collaborator

@AristideVB thank you again for the efforts here, really appreciate it. We are updating public APIs, and sample apps with the bigger change in question, we haven't decided yet, but we might expose a class for tracking which would be optional.

Once we have all the details figured out, if we are to use this code, we will merge the PR as it is, otherwise, we will make related changes wherever needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants