Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar Overlay Issue #217

Closed
vothsco opened this issue Sep 20, 2014 · 2 comments
Closed

Sidebar Overlay Issue #217

vothsco opened this issue Sep 20, 2014 · 2 comments

Comments

@vothsco
Copy link

vothsco commented Sep 20, 2014

CBOX member Tim reports that when positioning the menu under the header, and adding an overlay to the sidebar, the overlay slightly goes over the navigation section. It should be underneath. I have been able to reproduce and am attaching a screen shot to better explain. Here is a link to the forum topic: http://commonsinabox.org/groups/help-support/forum/topic/sidebar-problem/

tim

@christianwach
Copy link
Collaborator

@vothsco This issue was also raised in #210 and goes back to #161 if the layering issue is also considered.

The problem seems to be that the code that applies the z-index when there's a background overlay applies it too widely. The sidebar z-index ends up with a higher value than the container for the sub-menu. The only way that I can see of applying a different z-index to the sidebar is through the defaults as specified in the theme CSS files, but there may be unintended consequences on sites which have configurations that I haven't tried locally.

I've created a PR for review #218

@r-a-y
Copy link
Member

r-a-y commented Dec 26, 2014

Christian's fix was merged in #218. Closing.

@r-a-y r-a-y closed this as completed Dec 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants