fix more comments

Author: allanstone

facturapi/resources/invoices.py

@@ -216,12 +216,10 @@ def send_by_email(
             ValueError: If the invoice_id is not provided.
             requests.RequestException: If the API request fails.
         """
-        if not invoice_id:
-            raise ValueError("The invoice_id is required to send by email.")
 
         endpoint = f"{cls._resource}/{invoice_id}/email"
         payload = {}
-        if isinstance(recipients, (str, list)):
+        if recipients:
             payload["email"] = recipients
         response = client.post(endpoint, payload)
         return response.get("ok", False)

tests/resources/cassettes/test_send_invoice_by_email_invoice_not_found.yaml

@@ -0,0 +1,77 @@
+interactions:
+- request:
+    body: '{}'
+    headers:
+      Accept:
+      - '*/*'
+      Accept-Encoding:
+      - gzip, deflate
+      Authorization:
+      - DUMMY
+      Connection:
+      - keep-alive
+      Content-Length:
+      - '2'
+      Content-Type:
+      - application/json
+      User-Agent:
+      - facturapi-python/0.2.0
+    method: POST
+    uri: https://www.facturapi.io/v2/invoices/INVOICE_NOT_FOUND/email
+  response:
+    body:
+      string: '{"message":"Invoice with Id \"INVOICE_NOT_FOUND\" was not found or
+        you don''t have the right permissions","ok":false}'
+    headers:
+      Content-Length:
+      - '116'
+      access-control-allow-origin:
+      - '*'
+      content-security-policy:
+      - 'default-src ''self'' https://accounts.google.com/gsi/* https://*.stripe.com;font-src
+        https:;img-src data: https: https://*.stripe.com;script-src ''unsafe-inline''
+        https: https://accounts.google.com/gsi/client https://builder.io https://builder.io/*;style-src
+        https: ''unsafe-inline'' https://accounts.google.com/gsi/style;base-uri ''self'';object-src
+        ''none'';connect-src https: https://accounts.google.com/gsi/* https://*.stripe.com;frame-src
+        ''self'' *.stripe.com *.facebook.com https://accounts.google.com/ https://accounts.google.com/gsi/
+        https://accounts.google.com/gsi/* https://builder.io https://builder.io/*;frame-ancestors
+        ''self'' https://builder.io https://builder.io/*;upgrade-insecure-requests;form-action
+        ''self'';script-src-attr ''none'''
+      content-type:
+      - application/json; charset=utf-8
+      cross-origin-opener-policy:
+      - same-origin-allow-popups
+      cross-origin-resource-policy:
+      - same-site
+      date:
+      - Fri, 04 Apr 2025 02:59:28 GMT
+      etag:
+      - W/"74-9U2JIE0F589sz9k6Zf4ELoiLoa4"
+      origin-agent-cluster:
+      - ?1
+      referrer-policy:
+      - no-referrer
+      server:
+      - Google Frontend
+      strict-transport-security:
+      - max-age=15552000; includeSubDomains
+      x-cloud-trace-context:
+      - 34e5c1b94a06826421ee52ae05c02139/10885945258051611867;o=1
+      x-content-type-options:
+      - nosniff
+      x-dns-prefetch-control:
+      - 'off'
+      x-download-options:
+      - noopen
+      x-facturapi-log-id:
+      - 67ef4b105eb1f5f4a053ae9f
+      x-frame-options:
+      - SAMEORIGIN
+      x-permitted-cross-domain-policies:
+      - none
+      x-xss-protection:
+      - '0'
+    status:
+      code: 400
+      message: Bad Request
+version: 1

tests/resources/test_invoices.py

@@ -4,7 +4,11 @@
 from facturapi.resources.customers import CustomerRequest
 from facturapi.resources.invoices import InvoiceRequest
 from facturapi.types import FileType, PaymentForm
-from facturapi.types.exc import MultipleResultsFound, NoResultFound
+from facturapi.types.exc import (
+    FacturapiResponseException,
+    MultipleResultsFound,
+    NoResultFound,
+)
 from facturapi.types.general import CustomerAddress, ItemPart
 
 
@@ -107,36 +111,35 @@ def test_cancel_invoice():
 @pytest.mark.vcr
 def test_send_invoice_by_email_without_email():
     invoice_id = "67e59a55f4f823d3d978f3cb"
-    resp = facturapi.Invoice.send_by_email(invoice_id=invoice_id)
-
-    assert resp is True
+    email_sent = facturapi.Invoice.send_by_email(invoice_id=invoice_id)
+    assert email_sent
 
 
 @pytest.mark.vcr
 def test_send_invoice_by_email_with_email():
     invoice_id = "67e59a55f4f823d3d978f3cb"
     email = "frida_kahlo@test.com"
     recipients = [email]
-    resp = facturapi.Invoice.send_by_email(
+    email_sent = facturapi.Invoice.send_by_email(
         invoice_id=invoice_id, recipients=recipients
     )
-
-    assert resp is True
+    assert email_sent
 
 
 @pytest.mark.vcr
 def test_send_invoice_by_email_false():
     invoice_id = "INVOICE01"
-    resp = facturapi.Invoice.send_by_email(invoice_id=invoice_id)
+    email_sent = facturapi.Invoice.send_by_email(invoice_id=invoice_id)
+    assert not email_sent
 
-    assert resp is False
 
-
-def test_send_invoice_by_email_missing_invoice_id():
-    with pytest.raises(
-        ValueError, match="The invoice_id is required to send by email."
-    ):
-        facturapi.Invoice.send_by_email(invoice_id=None)
+@pytest.mark.vcr
+def test_send_invoice_by_email_invoice_not_found():
+    invoice_id = "INVOICE_NOT_FOUND"
+    with pytest.raises(FacturapiResponseException) as exc_info:
+        facturapi.Invoice.send_by_email(invoice_id=invoice_id)
+    exc_str = str(exc_info.value)
+    assert f'Invoice with Id "{invoice_id}" was not found' in exc_str
 
 
 @pytest.mark.vcr