omit documents with no test cases from results (#321)

Author: davidjgoss

samples/targeted-run.ts

@@ -6,6 +6,7 @@ import React, { VoidFunctionComponent } from 'react'
 import attachments from '../../../acceptance/attachments/attachments.feature'
 import examplesTables from '../../../acceptance/examples-tables/examples-tables.feature'
 import minimal from '../../../acceptance/minimal/minimal.feature'
+import targetedRun from '../../../samples/targeted-run'
 import SearchQueryContext, { useSearchQueryCtx } from '../../SearchQueryContext'
 import { EnvelopesWrapper } from './EnvelopesWrapper'
 import { FilteredResults } from './FilteredResults'
@@ -23,6 +24,30 @@ describe('FilteredResults', () => {
     )
   }
 
+  describe('with a targeted run', () => {
+    it('doesnt include features where no scenarios became test cases', () => {
+      const { getByRole, queryByRole } = render(
+        <TestableFilteredResults envelopes={targetedRun as Envelope[]} />
+      )
+
+      expect(
+        getByRole('heading', {
+          name: 'features/adding.feature',
+        })
+      ).toBeVisible()
+      expect(
+        queryByRole('heading', {
+          name: 'features/editing.feature',
+        })
+      ).not.toBeInTheDocument()
+      expect(
+        queryByRole('heading', {
+          name: 'features/empty.feature',
+        })
+      ).not.toBeInTheDocument()
+    })
+  })
+
   describe('searching', () => {
     it('shows a message for a search term that yields no results', async () => {
       const { getByRole, getByText } = render(

src/components/app/FilteredResults.spec.tsx

@@ -3,6 +3,7 @@ import { Story } from '@ladle/react'
 import React from 'react'
 
 import testData from '../../../acceptance/examples-tables/examples-tables.feature'
+import targetedRun from '../../../samples/targeted-run'
 import { CucumberReact } from '../CucumberReact'
 import { EnvelopesWrapper } from './EnvelopesWrapper'
 import { FilteredResults } from './FilteredResults'
@@ -32,3 +33,8 @@ export const Default = Template.bind({})
 Default.args = {
   envelopes: testData,
 }
+
+export const TargetedRun = Template.bind({})
+TargetedRun.args = {
+  envelopes: targetedRun,
+}

src/components/app/FilteredResults.stories.tsx

@@ -10,7 +10,6 @@ import styles from './FilteredResults.module.scss'
 import { GherkinDocumentList } from './GherkinDocumentList'
 import { NoMatchResult } from './NoMatchResult'
 import { SearchBar } from './SearchBar'
-import statuses from './statuses'
 import { StatusesSummary } from './StatusesSummary'
 
 interface IProps {
@@ -30,7 +29,7 @@ export const FilteredResults: React.FunctionComponent<IProps> = ({ className })
     search.add(gherkinDocument)
   }
 
-  const onlyShowStatuses = statuses.filter((s) => !hideStatuses.includes(s))
+  const onlyShowStatuses = statusesWithScenarios.filter((s) => !hideStatuses.includes(s))
 
   const matches = query ? search.search(query) : allDocuments
   const filtered = matches

src/components/app/FilteredResults.tsx

@@ -3,9 +3,8 @@ import { Query as GherkinQuery } from '@cucumber/gherkin-utils'
 import * as messages from '@cucumber/messages'
 import { Envelope, SourceReference, TestStepResultStatus } from '@cucumber/messages'
 import { Query as CucumberQuery } from '@cucumber/query'
-import fs from 'fs'
-import path from 'path'
 
+import targetedRun from '../samples/targeted-run'
 import { runFeature } from '../test-utils'
 import countScenariosByStatuses from './countScenariosByStatuses'
 import { EnvelopesQuery } from './EnvelopesQueryContext'
@@ -103,15 +102,9 @@ Feature: statuses
   })
 
   it('only includes pickles that were slated for execution as test cases', () => {
-    const raw = fs.readFileSync(
-      path.join(__dirname, '../test-utils/messages/filtered-pickles.ndjson'),
-      {
-        encoding: 'utf-8',
-      }
-    )
-    const envelopes: Envelope[] = JSON.parse('[' + raw.trim().split('\n').join(',') + ']')
     const gherkinQuery = new GherkinQuery()
     const cucumberQuery = new CucumberQuery()
+    const envelopes = targetedRun as Envelope[]
     envelopes.forEach((envelope) => {
       gherkinQuery.update(envelope)
       cucumberQuery.update(envelope)