Fix boolean parsing

aslakhellesoy · aslakhellesoy · commit de06f61d8da3 · 2022-07-27T11:07:53.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 
+### Fixed
+- Properties with `itemtype="http://schema.org/Boolean"` are parsed correctly. 
+
 ### Added
 - Support for `track`, `data` and `meter` elements
 
diff --git a/src/index.ts b/src/index.ts
@@ -101,9 +101,11 @@ function value(element: Element, extractValue: ExtractValue) {
     case 'https://schema.org/Integer':
       return Number(stringValue)
     case 'https://schema.org/Boolean':
+      return stringValue === 'true'
     case 'https://schema.org/False':
+      return false
     case 'https://schema.org/True':
-      return Boolean(stringValue)
+      return true
     default:
       throw new Error(
         `Unable to extract value. Change itemtype to a primitive type or add itemscope on element ${element.outerHTML}`
diff --git a/test/microdataTest.ts b/test/microdataTest.ts
@@ -22,12 +22,12 @@ type TreeList = {
 }
 
 describe('microdata', () => {
-  it('converts primitive types', () => {
+  it.only('converts primitive types', () => {
     const dom = new JSDOM(`<!DOCTYPE html>
     <div itemscope itemtype="https://schema.org/Event">
         <div>
             Maximum attendees: <span itemprop="maximumAttendeeCapacity" itemtype="https://schema.org/Integer">35</span>.
-            <meta itemprop="isAccessibleForFree" content="false"/>Ticket: pay at the entrance.
+            <meta itemprop="isAccessibleForFree" itemtype="https://schema.org/Boolean" content="false"/>Ticket: pay at the entrance.
         </div>
     </div>
     `)
