eth: bnxt: do not use BNXT_VNIC_NTUPLE unconditionally in queue restart logic

JIRA: https://issues.redhat.com/browse/RHEL-107291

commit 6619585
Author: Taehee Yoo <[email protected]>
Date:   Sun Mar 9 13:42:14 2025 +0000

    eth: bnxt: do not use BNXT_VNIC_NTUPLE unconditionally in queue restart logic

    When a queue is restarted, it sets MRU to 0 for stopping packet flow.
    MRU variable is a member of vnic_info[], the first vnic_info is default
    and the second is ntuple.
    Only when ntuple is enabled(ethtool -K eth0 ntuple on), vnic_info for
    ntuple is allocated in init logic.
    The bp->nr_vnics indicates how many vnic_info are allocated.
    However bnxt_queue_{start | stop}() accesses vnic_info[BNXT_VNIC_NTUPLE]
    regardless of ntuple state.

    Reviewed-by: Somnath Kotur <[email protected]>
    Fixes: b9d2956 ("bnxt_en: stop packet flow during bnxt_queue_stop/start")
    Signed-off-by: Taehee Yoo <[email protected]>
    Link: https://patch.msgid.link/[email protected]
    Signed-off-by: Jakub Kicinski <[email protected]>

Signed-off-by: Michal Schmidt <[email protected]>

Author: michich

drivers/net/ethernet/broadcom/bnxt/bnxt.c

@@ -15800,7 +15800,7 @@ static int bnxt_queue_start(struct net_device *dev, void *qmem, int idx)
 	napi_enable(&bnapi->napi);
 	bnxt_db_nq_arm(bp, &cpr->cp_db, cpr->cp_raw_cons);
 
-	for (i = 0; i <= BNXT_VNIC_NTUPLE; i++) {
+	for (i = 0; i <= bp->nr_vnics; i++) {
 		vnic = &bp->vnic_info[i];
 
 		rc = bnxt_hwrm_vnic_set_rss_p5(bp, vnic, true);
@@ -15834,7 +15834,7 @@ static int bnxt_queue_stop(struct net_device *dev, void *qmem, int idx)
 	struct bnxt_napi *bnapi;
 	int i;
 
-	for (i = 0; i <= BNXT_VNIC_NTUPLE; i++) {
+	for (i = 0; i <= bp->nr_vnics; i++) {
 		vnic = &bp->vnic_info[i];
 		vnic->mru = 0;
 		bnxt_hwrm_vnic_update(bp, vnic,