Skip to content

Commit 5a3e60c

Browse files
committed
csfilter: abstract out other precise numbers in Pylint output
Reported-By: Pavel Raiskup Fixes: https://github.com/kdudka/csdiff/issues/5
1 parent 4a06205 commit 5a3e60c

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

csfilter.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ struct MsgFilter::Private {
123123
addMsgFilter(checker, " \\([0-9]+/[0-9]+\\)$", "");
124124

125125
// "... Redefining name 'desc' from outer scope (line 10)" etc.
126-
addMsgFilter(checker, " \\(line [0-9]+\\)$", "");
126+
addMsgFilter(checker, " \\((?:imported )?line [0-9]+\\)$", "");
127127
}
128128

129129
// "__coverity_strcmp" -> "strcmp", etc.

tests/diff-misc/10-pylint-copr-new.err

+1
Original file line numberDiff line numberDiff line change
@@ -503,3 +503,4 @@ from sqlalchemy.sql import false,true
503503
/coprs_frontend/coprs/models.py:26:0: C0411[pylint]: standard import "import operator" should be placed before "from sqlalchemy import outerjoin"
504504
/coprs_frontend/coprs/models.py:29:0: C0411[pylint]: third party import "import gi" should be placed before "from copr_common.enums import ActionTypeEnum, BackendResultEnum, FailTypeEnum, ModuleStatusEnum, StatusEnum, DefaultActionPriorityEnum"
505505
/coprs_frontend/coprs/models.py:31:0: C0411[pylint]: third party import "from gi.repository import Modulemd" should be placed before "from copr_common.enums import ActionTypeEnum, BackendResultEnum, FailTypeEnum, ModuleStatusEnum, StatusEnum, DefaultActionPriorityEnum"
506+
/coprs_frontend/tests/test_views/test_coprs_ns/test_coprs_general.py:706:8: W0404[pylint]: TestCoprRepoGeneration.test_works_on_older_builds: Reimport 'app' (imported line 13)

tests/diff-misc/10-pylint-copr-old.err

+1
Original file line numberDiff line numberDiff line change
@@ -504,3 +504,4 @@ from sqlalchemy.sql import false,true
504504
/coprs_frontend/coprs/models.py:26:0: C0411[pylint]: standard import "import operator" should be placed before "from sqlalchemy import outerjoin"
505505
/coprs_frontend/coprs/models.py:29:0: C0411[pylint]: third party import "import gi" should be placed before "from copr_common.enums import ActionTypeEnum, BackendResultEnum, FailTypeEnum, ModuleStatusEnum, StatusEnum, DefaultActionPriorityEnum"
506506
/coprs_frontend/coprs/models.py:31:0: C0411[pylint]: third party import "from gi.repository import Modulemd" should be placed before "from copr_common.enums import ActionTypeEnum, BackendResultEnum, FailTypeEnum, ModuleStatusEnum, StatusEnum, DefaultActionPriorityEnum"
507+
/coprs_frontend/tests/test_views/test_coprs_ns/test_coprs_general.py:607:8: W0404[pylint]: TestCoprRepoGeneration.test_works_on_older_builds: Reimport 'app' (imported line 31)

0 commit comments

Comments
 (0)