csparser: add double_unlock as key event for LOCK

Author: kdudka

csparser.cc

@@ -239,6 +239,7 @@ KeyEventDigger::KeyEventDigger():
     d->hMap["FORWARD_NULL"]         .insert("dereference");
     d->hMap["FORWARD_NULL"]         .insert("var_deref_op");
     d->hMap["FORWARD_NULL"]         .insert("var_deref_model");
+    d->hMap["LOCK"]                 .insert("double_unlock");
     d->hMap["NESTING_INDENT_MISMATCH"].insert("dangling_else");
     d->hMap["NESTING_INDENT_MISMATCH"].insert("multi_stmt_macro");
     d->hMap["NESTING_INDENT_MISMATCH"].insert("on_same_line");
@@ -266,9 +267,6 @@ KeyEventDigger::KeyEventDigger():
     d->hMap["CLANG_WARNING"]        .insert("warning");
     d->hMap["CLANG_WARNING"]        .insert("fatal error");
 
-    // do not match the lowered checker name of the following checkers
-    d->hMap["LOCK"];
-
     // events that should never be used as key events (excluding trace events)
     d->blackList.insert("another_instance");
     d->blackList.insert("comparison_remediation");

tests/csgrep/44-csparser-new-key-evts-stdin.txt

@@ -127,3 +127,12 @@ Error: BAD_FREE (CWE-763):
 bind-9.11.3/lib/isc-pkcs11/mem.c:1592: address_assign: Assigning: "si" = "&(size_info *)ptr[-2]".
 bind-9.11.3/lib/isc-pkcs11/mem.c:1608: incorrect_free: "mem_put" frees incorrect pointer "si".
 bind-9.11.3/lib/isc-pkcs11/mem.c:804:1: function_annotation: Applying function annotation "free" to all paths.
+
+Error: LOCK (CWE-667):
+389-ds-base-1.3.8.4/ldap/servers/plugins/replication/repl5_ruv.c:1409: unlock: "ruv_replica_count" unlocks "ruv->lock".
+389-ds-base-1.3.8.4/ldap/servers/plugins/replication/repl5_ruv.c:1377:9: lock: "slapi_rwlock_rdlock" locks "ruv->lock".
+389-ds-base-1.3.8.4/ldap/servers/slapd/slapi2nspr.c:221:9: lock: "pthread_rwlock_rdlock" locks "rwlock".
+389-ds-base-1.3.8.4/ldap/servers/plugins/replication/repl5_ruv.c:1379:9: unlock: "slapi_rwlock_unlock" unlocks "ruv->lock".
+389-ds-base-1.3.8.4/ldap/servers/slapd/slapi2nspr.c:253:9: unlock: "pthread_rwlock_unlock" unlocks "rwlock".
+389-ds-base-1.3.8.4/ldap/servers/plugins/replication/repl5_ruv.c:1428: double_unlock: "slapi_rwlock_unlock" unlocks "ruv->lock" while it is unlocked.
+389-ds-base-1.3.8.4/ldap/servers/slapd/slapi2nspr.c:253:9: unlock: "pthread_rwlock_unlock" unlocks "rwlock".

tests/csgrep/44-csparser-new-key-evts-stdout.txt

@@ -57,3 +57,6 @@ apache-tomcat-9.0.7.redhat-10-src/java/org/apache/tomcat/websocket/WsFrameBase.j
 
 Error: BAD_FREE (CWE-763):
 bind-9.11.3/lib/isc-pkcs11/mem.c:1608: incorrect_free: "mem_put" frees incorrect pointer "si".
+
+Error: LOCK (CWE-667):
+389-ds-base-1.3.8.4/ldap/servers/plugins/replication/repl5_ruv.c:1428: double_unlock: "slapi_rwlock_unlock" unlocks "ruv->lock" while it is unlocked.