ruby stuff #1
Open
ruby stuff #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your code is starting to look beautiful! Good job! Please squish your commits after making these changes so I can see the whole code and do one more pass on it. |
|
I rebased your code against my master, and did some surgery to get everything in one commit. Please pull this branch and use it as your master: https://github.com/csail/6006psets_ng/tree/sharon I'm posting my comments here: 837c03c |
|
Done reviewing. It's getting close! |
|
Hi, Sharon. I merged your commits again and put them in the |
ghost
assigned
|
Hi, Sharon. I'm done commenting. I think this is the last set of comments I'll have. Please fix and derive |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.