Skip to content

Commit 045c3b6

Browse files
committed
Replaced oldfind with newfind command
1 parent 8cd6e1a commit 045c3b6

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

changelog/unreleased/eos-newfind.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
Enhancement: use newfind command in EOS
2+
3+
The EOS binary storage driver was still using EOS's oldfind command, which is deprecated. We now moved to the new find command, for which an extra flag (--skip-version-dirs) is needed.
4+
5+
https://github.com/cs3org/reva/pull/4883

pkg/eosclient/eosbinary/eosbinary.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -722,7 +722,7 @@ func (c *Client) ListWithRegex(ctx context.Context, auth eosclient.Authorization
722722

723723
// List the contents of the directory given by path.
724724
func (c *Client) List(ctx context.Context, auth eosclient.Authorization, path string) ([]*eosclient.FileInfo, error) {
725-
args := []string{"oldfind", "--fileinfo", "--maxdepth", "1", path}
725+
args := []string{"newfind", "--fileinfo", "--skip-version-dirs", "--maxdepth", "1", path}
726726
stdout, _, err := c.executeEOS(ctx, args, auth)
727727
if err != nil {
728728
return nil, errors.Wrapf(err, "eosclient: error listing fn=%s", path)

0 commit comments

Comments
 (0)