Feature Request: option to automatically inspect Simple FEL during -scan operation

[rcork]

I'd love to see an optional parameter added to -scan that will do deep inspection of any Simple FEL identified during a scan. For example:

dovi_convert -scan -inspect-simple -r [path to media]

This would simplify and automate a process that today requires invoking inspect individually for every Simple FEL file identified during a scan operation.

[cryptochrome]

Hey, thanks for the suggestion. It's an interesting idea that is worth exploring.

The only issue with it that I see is that this could take forever, depending on how many Simple-FEL it finds and how fast a user's system is.

What would you expect the outcome to be if we include -inspect in the -scan? Should the conversion automatically continue if the -inspect verdict is "safe"? Or would you still like to retain control over this?

[rcork]

Since -scan doesn't convert anything and only outputs the analysis, adding -inspect-simple to the -scan option could just print the same output that -scan produces but when it finds a simple FEL (which is based on 10 samples), it could then run the deeper inspect pass and print whether it's safe or not. I agree that it could take a long time but for those of us that want to make sure the files are truly Simple and not Complex, we end up running inspect on every Simple FEL file anyways so maybe just print a warning when the option is used to let the user know this could take a long time and confirm to proceed.

[cryptochrome]

Yes, makes sense. I was thinking ahead. What if we want to use that result in -convert (or even -batch). If the use case is just to enhance -scan, this is somewhat trivial to implement.

We would just need to think about the UI for that, and the logic.

A very simple approach would be to do this "inline", e.g. as soon as a Simple-FEL is detected, the -scan is paused and we run -inspect, print the verdict and then continue.

A slightly more involved approach would be to first complete the -scan entirely (so you see a first result immediately). Then queue up all the Simple-FELs and run -inspect on them, and print the vedicts separately.

What do you think?

[rcork]

I like your second option. It preserves all the output from the original scan pass and then gives a separate output for the inspect pass. But your call.

[cryptochrome]

I like the second option better, too. Alright. I will put this on my ever growing list of features to add :) Thanks for the suggestion. Expect it to get implemented, I just can't give you an ETA yet.