Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of eval is strongly discouraged. #83

Open
metr-o opened this issue Jul 7, 2022 · 1 comment
Open

Use of eval is strongly discouraged. #83

metr-o opened this issue Jul 7, 2022 · 1 comment

Comments

@metr-o
Copy link

metr-o commented Jul 7, 2022

cosmos-signer seems to use a library cosmjs-types (and other imported library's in this repo) which are using protobufjs which is importing a library quire using eval instead of importing it normally.

image

Is another issue directly opened on the mentioned packages repo.
protobufjs/protobuf.js#1754

While the implementation of eval from protobufjs may not be too problematic security wise it's causing a warning on build time by rollup which could obfuscate another eval call that is introduced by another library (that could be a threat) when a user has also imported your package.

https://rollupjs.org/guide/en/#avoiding-eval

@AntiMoron
Copy link

support me, protobufjs/protobuf.js#1941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants