-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve dynamic libraries loading #17
Comments
Thanks for the suggestion, we will look into this. |
@adnan-kamili what is the current status? Can you share a rough ETA? |
In the case of LexActivator, it has to be true as it stores data on disk and also accesses a few files on the disk for its proper functioning. |
That's totally true, but Python tries to abstract that by using |
Ok, that makes sense. Would it be possible for you to submit a pull request? |
I tried to come up with some solution but without a success. I can give it a shot next time I'll be working on licensing area, but it won't be soon. |
Currently lexactivator is using
__file__
variable for path resolution (see: https://github.com/cryptlex/lexactivator-python/blob/master/cryptlex/lexactivator/lexactivator_native.py#L47)The problem with that approach is that the code assumes it will have access to the file system which is not always true.
From Python 3.8, ResourceReader and importlib.resources are recommended ways of accessing package resources that enables interoprability across the Python ecosystem with projects like https://github.com/indygreg/PyOxidizer.
A more in-depth description of various loading mechanisms is available here
The text was updated successfully, but these errors were encountered: