Feat: Add ORP and PH sensors

[spraguej248]

I have both the ORP and PH sensors and automatic dispensers. I'm happy to help out with testing if the need arises.

Thanks for the great integration!

[cryptk]

Can you start by pulling the diagnostic data from the integration and attaching it to this issue? My kids go back to school in a couple of weeks and I should have time to work on some of these features once that happens.

[spraguej248]

Sure, I'm attaching it here. Thanks!

config_entry-omnilogic_local-e54490100346440d70659401fd412bc4.json.txt

[matthew-larner]

I really appreciate your work on this @cryptk and @spraguej248. I'm just about to buy an Omnilogic system so this feature would be amazing. I'm happy to beta test too if that helps.

[Tobypoodle]

Hi, I also have ORP and PH sensors so would love to see these added. I use the HL-CHEM "Sense and Dispense" that the Omnilogic then controls little chem pumps for liquid chlorine and muratic acid.

Great integration, good to see a local version as the Omnilogic servers can flake regularly and nice to be able to see/control things from the local network. Let me know how I can help as I am somewhat technical.

[cryptk]

@matthew-larner @Tobypoodle @spraguej248 can you please install version 0.7.3 from HACS and see if you have pH sensors now? Once you verify that, I can get ORP in as well.

[matthew-larner]

Great thanks! It will be another month before my omnilogic system is installed, but I'll be happy to test then.

[spraguej248]

I do have the ph sensor coming through now, thank you! A minor thing though, the value that comes through does not include the ph offset. For ph, in the Omnilogic app, there is a field where you manually enter a number to correct the value of the ph. Is it possible to add a blank offset field in the configuration, then show the sum of the actual ph value from omnilogic plus the offset as the ph sensor value? The home assistant omnilogic core integration does this as well. Screenshot below. The offset field exists in the configuration section. The displayed ph sensor value is the sum of the actual omnilogic value plus the ph offset. This is only required for the ph. There is no adjustment for ORP. [image: image.png] Thank you!!!

…

On Fri, Jun 7, 2024 at 7:27 PM Matt ***@***.***> wrote: Great thanks! It will be another month before my omnilogic system is installed, but I'll be happy to test then. — Reply to this email directly, view it on GitHub <#73 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AF5XVHSEWW3VHK2OTGFY4IDZGJFWJAVCNFSM6AAAAABI7M3XXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJVG4ZDEMRSHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Tobypoodle]

Yep, can see PH now, great and thank you! Ditto spraguej248 comments on PH offset.

[cryptk]

I have the data for the pH offset in the integration already, I just assumed that the pH value was already including that offset, evidently it isn't. I'm going to be busy for the next couple of days, but I'll get a version pushed out that offsets the value properly.

[amattas]

I was going to fork and work on this - I just installed one of these devices, this is awesome!

[cryptk]

@amattas feel free to send in pull requests! I didn't work on the project much over the winter because I wasn't using my pool, but now that we're back into pool season, I'm hoping to knock out some of the various feature requests and issues

[cryptk]

#104 should fix the calibration offset issue as well as add some extra data as attributes to the sensor (ORP, raw value, calibration offset, high/low alarm thresholds, etc).

Take a look at version 0.7.4 and let me know if I need to address this further! One thing that I wasn't sure on is if I should split ORP out to its own sensor... Let me know what you all think

[spraguej248]

Yes, the ph sensor pulls the adjusted number correctly now. Nice you are able to get the adjusted number and not have to worry about it in HA. Thanks! :) Here's the other sensors/controls I see in 0.7.4. I see that there is a chlorinator switch which does turn my sense & dispense chlorinator on/off (not sure if that was there previously?). Here's some screen shots showing what comes over from 0.7.4. Thank you! [image: image.png] [image: image.png]

…

On Sun, Jun 9, 2024 at 4:34 PM cryptk ***@***.***> wrote: #104 <#104> should fix the calibration offset issue as well as add some extra data as attributes to the sensor (ORP, raw value, calibration offset, high/low alarm thresholds, etc). Take a look at version 0.7.4 and let me know if I need to address this further! — Reply to this email directly, view it on GitHub <#73 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AF5XVHWP24GRJIMQWOIIOWDZGTC6PAVCNFSM6AAAAABI7M3XXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJWG44TSNRXGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[amattas]

So I just updated to 0.7.5 and PH showed up, but I don't see ORP. And then I just read back through and realized it was under the PH sensor.

I'd probably break it out from a usability standpoint. With it combined I can't use the default trend charts, etc that you get either.

[cryptk]

Opened #106 to handle some more improvements for the Sense and dispense equipment, including splitting the orp out to its own sensor