Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add an example contract to validate DaoActionData #23

Closed
9 tasks done
Tracked by #16
doitian opened this issue Jan 11, 2024 · 0 comments · Fixed by #28, #29, #36, #37 or #38
Closed
9 tasks done
Tracked by #16

✨ Add an example contract to validate DaoActionData #23

doitian opened this issue Jan 11, 2024 · 0 comments · Fixed by #28, #29, #36, #37 or #38
Assignees
Labels
enhancement New feature or request

Comments

@doitian
Copy link
Collaborator

doitian commented Jan 11, 2024

Architecture

DerivedDaoActionData is responsible to verify deposit to, withdraw and claim from

  • Derive dao operations from tx DerivedDaoActionData#derive
  • Verify that the derived operations can be found in the CoBuild message, and there are now two derived operations mapping to the same operation in the CoBuild message. DerivedDaoActionData#verify
  • Verify that all derived operations can be found. DerivedDaoActionData#complete

DerivedCkbAccounting is responsible to verify deposit from and claim to

  • Accumulate accounting requirements from CoBuild message DerivedCkbAccounting#derive
  • Tally the CKB balance in tx and verify the account balances are sufficient DerivedCkbAccounting#verify
@doitian doitian moved this to In Progress in ckb-dao-cobuild-poc Jan 11, 2024
@doitian doitian linked a pull request Jan 11, 2024 that will close this issue
@doitian doitian changed the title Add an example contract to validate DaoActionData. ✨ Add an example contract to validate DaoActionData. Jan 11, 2024
@doitian doitian removed a link to a pull request Jan 11, 2024
This was linked to pull requests Jan 11, 2024
@doitian doitian self-assigned this Jan 22, 2024
@doitian doitian added the enhancement New feature or request label Jan 23, 2024
@doitian doitian linked a pull request Feb 1, 2024 that will close this issue
@doitian doitian changed the title ✨ Add an example contract to validate DaoActionData. ✨ Add an example contract to validate DaoActionData Feb 1, 2024
@doitian doitian removed a link to a pull request Feb 1, 2024
@doitian doitian pinned this issue Feb 1, 2024
@doitian doitian moved this from In Progress to In Review in ckb-dao-cobuild-poc Feb 2, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in ckb-dao-cobuild-poc Feb 9, 2024
@doitian doitian reopened this Feb 9, 2024
@doitian doitian unpinned this issue Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment