Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make dev broken due to file removed from crossplane repository #104

Open
MrVinkel opened this issue May 31, 2024 · 1 comment · May be fixed by #111
Open

make dev broken due to file removed from crossplane repository #104

MrVinkel opened this issue May 31, 2024 · 1 comment · May be fixed by #111
Labels
bug Something isn't working

Comments

@MrVinkel
Copy link

What happened?

Hi, we have a couple of custom providers based on this template for some internal services.

The kustomization.yaml used in make dev was deleted from the crossplane repository a couple of days ago by @negz

crossplane/crossplane@ea9e439

The yaml file is used by make dev to initialize the local development environment for the provider.

https://github.com/crossplane/provider-template/blob/main/Makefile#L95

I can use another ref to fetch the CRDs, but what is the permanent fix?

In general this provider template does not seem to get very much attention, and it is pretty rough to work with.

How can we reproduce it?

Create a new provider from this template and run make dev

What environment did it happen in?

Crossplane version:

Crossplane v1.16.0
Latest version of this provider

@MrVinkel MrVinkel added the bug Something isn't working label May 31, 2024
@negz
Copy link
Member

negz commented May 31, 2024

I can use another ref to fetch the CRDs, but what is the permanent fix?

I don't think these CRDs are actually needed by the make dev target. My best guess is they were copied by mistake in #19. So that line could just be removed from the Makefile.

Off the top of my head, I can't think of any reason why installing a provider into a kind cluster would need Crossplane core CRDs to be installed. If I'm forgetting something, the Makefile could easily get the same CRDs installed by installing the Crossplane Helm chart per https://docs.crossplane.io/v1.16/software/install/#install-pre-release-crossplane-versions.

In general this provider template does not seem to get very much attention, and it is pretty rough to work with.

Yes, help wanted. I'm the only person listed in OWNERs.md who still works on Crossplane and I'm spread too thin to give this template the attention it deserves.

JohanSandblom3 added a commit to JohanSandblom3/provider-template-104 that referenced this issue Oct 16, 2024
JohanSandblom3 added a commit to JohanSandblom3/provider-template-104 that referenced this issue Oct 16, 2024
@JohanSandblom3 JohanSandblom3 linked a pull request Oct 16, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants